1745795 - Avoid confusions between SourceFront and source objects in debugger reducer

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Alexandre Poirot [:ochameau]]

At least in newGeneratedSources function, we refer to a source variable, which isn't the source object of the sources reducer:
https://searchfox.org/mozilla-central/rev/4646b826a25d3825cf209db890862b45fa09ffc3/devtools/client/debugger/src/actions/sources/newSources.js#281
This is actually a reference to a SourceFront.
The goals of this bug is to clarify that by renaming it to sourceFront.
Ideally, when we are using a source variable anywhere in debugger frontend, it should refer to the sources.js reducer objects.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1745795 - [devtools] Avoid confusion between "reducer source" and "SourceFront" objects.

I'm also removing the isBlackBoxed boolean from source actor in the reducer
in order to ensure we always only use the source reducer one.

And I dropped some comment here and there to help understand where all these sources objects are coming from.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5022fa8d4e3d
[devtools] Avoid confusion between "reducer source" and "SourceFront" objects. r=bomsy

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5022fa8d4e3d