1690467 - Date/time picker broken

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

The introduction of a gBrowser in bug 810814 bug 810815 has broken the date/time picker, which was relying on the non-existence of gBrowser to work. Gah.

Comment 1

[Geoff Lankow (:darktrojan)]

Or bug 810815.

Comment 2

[Geoff Lankow (:darktrojan)]

It seems like gBrowser is no longer required by pdf.js, so I can remove it.

Comment 3

[Mark Banner (:standard8)]

I just tried this locally, and it gives errors when you load a pdf:

TypeError: can't access property "getTabForBrowser", tabbrowser is null
_hookupEventListeners resource://pdf.js/PdfjsParent.jsm:232
    _addEventListener resource://pdf.js/PdfjsParent.jsm:222
    receiveMessage resource://pdf.js/PdfjsParent.jsm:84

These seem related to the find bar - they don't seem to stop it working, but I would be concerned about removing them.

You could possibly see if aliasing tabbrowser to tabmail might work.

Comment 4

[Mark Banner (:standard8)]

There's also quite a bit of toolkit items that depend on gBrowser: https://searchfox.org/mozilla-central/search?q=gbrowser&path=toolkit&case=false&regexp=false

Not saying you can't remove it, but I think this needs careful examination.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1690467 - Fix date/time picker by removing gBrowser variable. r?mkmelin

The presence of gBrowser confuses the DateTimePicker actor. Since pdf.js has now been updated to run without gBrowser (instead using browser.getTabBrowser) this patch removes it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c1f37ca8340
Fix date/time picker by removing gBrowser variable. r=mkmelin

Comment 7

[Geoff Lankow (:darktrojan)]

Comment on attachment 9201029 [details]
Bug 1690467 - Fix date/time picker by removing gBrowser variable. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 810815
User impact if declined: HTML <input type=date> won't work
Testing completed (on c-c, etc.): on c-c with a new test since yesterday
Risk to taking this patch (and alternatives if risky): maybe, as Mark mentioned we're removing a variable toolkit uses, but it's only been there months and we've been careful to make sure stuff works without it in the past, so I think it's fine.

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9201029 [details]
Bug 1690467 - Fix date/time picker by removing gBrowser variable. r?mkmelin

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 86.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/a6f90f7edce3