1690605 - don't update source code of page

Status: RESOLVED WORKSFORME

(Toolkit :: View Source, defect)

Description

[fel1992]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

1. open page on localhost
2. open source code of this page (via right mouse click -> Source code of page (Исходный код страницы))
3. update page on localhost
4. update page in browser (changes shown)
5. open source code of this page again

Actual results:

and I see old source code

Expected results:

I want to see updated source code

Comment 1

[fel1992]

but source code updates after I update page (tab) with source code

Comment 2

[Daniel Bodea [:danibodea]]

I can confirm this behavior using the following steps to reproduce:

1. Create a local webpage (copy code from https://www.dummies.com/web-design-development/site-development/a-sample-web-page-in-html/)
2. (Install Python3) Open the terminal and start a simple server with the command: python3 -m http.server
3. Open browser and load "localhost:8000"
4. Navigate to the local webpage created in step 1 and open it.
5. Right-click in the content area and select "View source code"
6. Open the local webpage in a text editor and make some changes that would be easily visible and save the changes.
7. Refresh the page in the browser.
   Notice: The changes are visible.
8. Right-click in the content area and select "View source code"

Actual result: Notice that the changes that were visible in the page after refresh are not visible in the source code.
Expected result: The changes that were visible in the page after refresh should also be visible in the source code.

I noticed that the ESR version is not affected so I attempted investigating for a regressor. These are my test results:

2021-02-08T20:31:03.494000: DEBUG : Found commit message:
Bug 1651134 - do not partition view-source: pages r=baku

Differential Revision: https://phabricator.services.mozilla.com/D83122

2021-02-08T20:31:03.494000: DEBUG : Did not find a branch, checking all integration branches
2021-02-08T20:31:03.495000: INFO : The bisection is done.
2021-02-08T20:31:03.496000: INFO : Stopped

Tested in Windows 10.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can't reproduce this on my machine (Win10 + Firefox 96 Nightly)
I can see changes when viewing the page source (using "View Page Source" from the context menu)

@Bodea, @fel1992 : are you still seeing the problem?

Honza

Comment 4

[Daniel Bodea [:danibodea]]

Can no longer reproduce this, either.
While attempting to find the fix, all builds between Nightly (v96.0a1) from 2021-12-6 through to 2021-01-02 appear to not reproduce the issue, in contrary to previous test results. The previous cause of reproduction is unknown.