1651134 - View Source shows source code of login page instead of current webpage on local django server

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect)

Description

[bull500]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Start and run local django server. Login with credentials.
Right click on page and use 'View Source' option

Actual results:

View Source shows the source code of the login page instead of the page where the user clicked.

Expected results:

Show the source code of the current webpage instead of the source code of the login page.

moz-regression found that - Bug 1644111 : Remove isEnabled() check - started this problem.
The good and bad dates are = 2020-06-23 and 2020-06-24

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Could be a devtools problem but I'm not sure. Sending to the JS team to have a first look as they introduced the regression.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1651134 - Add isEnabled() check.

maybeResizeNursery() may update capacity_ so we still need the isEnabled() check.

Comment 4

[Kim Moir [:kmoir] ET]

jonco: Triaging as REO for 79 - can you set a priority and severity for this bug?

Comment 5

[Jon Coppeard (:jonco)]

(In reply to bull500 from comment #0)

moz-regression found that - Bug 1644111 : Remove isEnabled() check - started this problem.

It's really unlikely that this change could have produced this symptom. Is it possible that another change around the same time could have done this?

I noticed bug 1628486 landed just before this. Could that have caused this?

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to bull500 from comment #0)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Start and run local django server. Login with credentials.
Right click on page and use 'View Source' option

Actual results:

View Source shows the source code of the login page instead of the page where the user clicked.

Expected results:

Show the source code of the current webpage instead of the source code of the login page.

Can you show me the login url? And upload the screenshot of the expected webpage and actual webpage shown?
Or have you changed any pref?

So I tried https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Admin_site
with the login url 127.0.0.1:8000/admin/
after login, right click to view page source
I got the correct viewsource and cannot reproduce your problem.

Comment 7

[bull500]

(In reply to Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh] from comment #6)

(In reply to bull500 from comment #0)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Start and run local django server. Login with credentials.
Right click on page and use 'View Source' option

Actual results:

View Source shows the source code of the login page instead of the page where the user clicked.

Expected results:

Show the source code of the current webpage instead of the source code of the login page.

Can you show me the login url? And upload the screenshot of the expected webpage and actual webpage shown?
Or have you changed any pref?

So I tried https://developer.mozilla.org/en-US/docs/Learn/Server-side/Django/Admin_site
with the login url 127.0.0.1:8000/admin/
after login, right click to view page source
I got the correct viewsource and cannot reproduce your problem.

i've uploaded a Django site project here - https://www.mediafire.com/file/ux1olqftc2xapig/mysite.zip/file

You can use it to test it out
You'll have to do the steps of :
python manage.py makemigrations
python manage.py migrate
python manage.py createsuperuser
python manage.py runserver

once all that is done login via 'sign in' button on the home page - 127.0.0.1:8000

you can check the difference in 'view source' from the following links after sign in:
http://127.0.0.1:8000/list - normal
http://127.0.0.1:8000/create - problem

Comment 8

[Gary Chen [:xeonchen]]

(In reply to Jon Coppeard (:jonco) from comment #5)

(In reply to bull500 from comment #0)

moz-regression found that - Bug 1644111 : Remove isEnabled() check - started this problem.

It's really unlikely that this change could have produced this symptom. Is it possible that another change around the same time could have done this?

I noticed bug 1628486 landed just before this. Could that have caused this?

Probably not, but it's easy to check.

Could you help to check this?

1. open about:config
2. set network.cookie.cookieBehavior from 5 to 4

And see if this affects the result?

Comment 9

[bull500]

(In reply to Gary Chen [:xeonchen] from comment #8)

(In reply to Jon Coppeard (:jonco) from comment #5)

(In reply to bull500 from comment #0)

moz-regression found that - Bug 1644111 : Remove isEnabled() check - started this problem.

It's really unlikely that this change could have produced this symptom. Is it possible that another change around the same time could have done this?

I noticed bug 1628486 landed just before this. Could that have caused this?

Probably not, but it's easy to check.

Could you help to check this?

1. open about:config
2. set network.cookie.cookieBehavior from 5 to 4

And see if this affects the result?

Yes, it did!
It shows the correct source code.

Comment 10

[Gary Chen [:xeonchen]]

(In reply to bull500 from comment #9)

Yes, it did!
It shows the correct source code.

Thank you! This might be a breakage of dFPI.

Comment 11

[Gary Chen [:xeonchen]]

(In reply to bull500 from comment #7)

you can check the difference in 'view source' from the following links after sign in:
http://127.0.0.1:8000/list - normal
http://127.0.0.1:8000/create - problem

Just tested with the given site and it is reproducible, thank you!

The issue here is because the view-source tab is partitioned by "http://127.0.0.1:8000", and therefore a page required login is not accessible.
It explains why those two pages show different results.

Comment 12

[Gary Chen [:xeonchen]]

Attachment: Bug 1651134 - do not partition view-source: pages

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/346a9a9d3b14
do not partition view-source: pages r=baku

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/346a9a9d3b14

Comment 15

[bull500]

Thank you for fixing this! :D

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this ready for a Beta approval request?

Comment 17

[Gary Chen [:xeonchen]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #16)

Is this ready for a Beta approval request?

This only affects when network.cookie.cookieBehavior=5, and we only show UI to select this value in Nightly channel.
Should we uplift it? Is so, I think it's ready.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

If this isn't enabled by default on Beta/Release, I think we're fine letting it ride the 80 train. Thanks!