1690747 - Should also check if blur is allowed in BrowsingContext::Blur()

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Comment 1

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=015f234e866a68b6bd29089d40952e8b8204ba61

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1690747 - Should also check blur is allowed in BrowsingContext::Blur();

When binding delegates blur() to BrowsingContext::Blur, the remote side will
skip the check given that there is no js on the stack.

I spent some time trying to find a case that shows the current code could possiblly
cause a unexpected behavior, but unable to. Because the focus state isn't changed
at all even if we run nsGlobalWindowOuter::BlurOuter unconditionally, e.g setting
dom.disable_window_flip to false.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebb61065ad47
Should also check blur is allowed in BrowsingContext::Blur(); r=hsivonen

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing mochitests at /test_focus_design_mode.html
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=CCctQX-1R7Wb32irCKR38Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ebb61065ad47bcb98d80b0b0b0640f645837f53f
Failure log: https://treeherder.mozilla.org/logviewer?job_id=329352116&repo=autoland&lineNumber=2779

[task 2021-02-09T12:52:35.039Z] 12:52:35 INFO - TEST-START | dom/base/test/test_focus_design_mode.html
[task 2021-02-09T12:52:35.040Z] 12:52:35 INFO - Buffered messages logged at 12:52:32
[task 2021-02-09T12:52:35.040Z] 12:52:35 INFO - add_task | Entering test activeElementAfterBluring
[task 2021-02-09T12:52:35.040Z] 12:52:35 INFO - TEST-PASS | dom/base/test/test_focus_design_mode.html | check activeElement
[task 2021-02-09T12:52:35.040Z] 12:52:35 INFO - Buffered messages finished
[task 2021-02-09T12:52:35.040Z] 12:52:35 WARNING - TEST-UNEXPECTED-FAIL | dom/base/test/test_focus_design_mode.html | check activeElement after bluring - got "innerlog:windowfocus,activeElement:HTML,activeElement:BODY,", expected "innerlog:windowfocus,activeElement:HTML,activeElement:HTML,"
[task 2021-02-09T12:52:35.041Z] 12:52:35 INFO - SimpleTest.is@SimpleTest/SimpleTest.js:500:14
[task 2021-02-09T12:52:35.041Z] 12:52:35 INFO - activeElementAfterBluring@dom/base/test/test_focus_design_mode.html:52:5
[task 2021-02-09T12:52:35.041Z] 12:52:35 INFO - add_task | Leaving test activeElementAfterBluring
[task 2021-02-09T12:52:35.041Z] 12:52:35 INFO - TEST-OK | dom/base/test/test_focus_design_mode.html | took 163ms

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27cad0f0770c
Backed out changeset ebb61065ad47 for failing mochitests at test_focus_design_mode.html on a CLOSED TREE

Comment 6

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=817d61db83adef5e241c5b6188db01e2f05a7371

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d644dc9bc63
Should also check blur is allowed in BrowsingContext::Blur(); r=hsivonen

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5d644dc9bc63