Closed Bug 1690954 Opened 6 months ago Closed 2 months ago

<select> drop arrow hard to see with non-native theme

Categories

(Core :: Widget, defect)

Firefox 87
Desktop
All
defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox87 --- disabled
firefox88 --- disabled
firefox89 --- verified
firefox90 --- verified

People

(Reporter: sam, Assigned: emilio)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

When using the non-native theme, the drop arrow on <select> elements is now shown on top of the background color of the control, rather than having a visible button. This means that the arrow is now very hard or impossible to see with certain background colors.

I compared the behavior with Chrome, and they seem to use the foreground color for their drop arrow, so it is always easily seen.

Attached file example.html

This is the example from the comparison above.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(emilio)
Assignee: nobody → emilio
Status: NEW → ASSIGNED

Comment on attachment 9222127 [details]
Bug 1690954 - Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame,spohl

Beta/Release Uplift Approval Request

  • User impact if declined: Comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial color change to match the text color of the <select>.
  • String changes made/needed: none
Flags: needinfo?(emilio)
Attachment #9222127 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9222127 [details]
Bug 1690954 - Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame,spohl

Low risk and a fix for an issue that may become very visible as we are now shipping non-native form theming, approved for 89 beta 14 after it has landed on mozilla-central, thanks.

Attachment #9222127 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b01dc039dbc
Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame

Low risk and a fix for an issue that may become very visible as we are now shipping non-native form theming, approved for 89 beta 14 after it has landed on mozilla-central, thanks.

In that case, setting Beta status-firefox89=affected.

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
QA Whiteboard: [qa-triaged]

This fix was reproduced and verified in Nightly v90.0a1, builds before and after the fix on WIndows 10, Mac OS 11.3.1 and Ubuntu 20. The arrow on the button is now showing the correct color.
Waiting for the fix to be uplifted.

OS: Unspecified → All
Hardware: Unspecified → Desktop

Confirmed as fixed on Beta v89.0b14 on Windows 10, Mac OS 11.3.1 and Ubuntu 20.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.