1690954 - <select> drop arrow hard to see with non-native theme

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Sam Johnson]

Attachment: Top: Firefox; Bottom: Chrome

When using the non-native theme, the drop arrow on <select> elements is now shown on top of the background color of the control, rather than having a visible button. This means that the arrow is now very hard or impossible to see with certain background colors.

I compared the behavior with Chrome, and they seem to use the foreground color for their drop arrow, so it is always easily seen.

Comment 1

[Sam Johnson]

Attachment: example.html

This is the example from the comparison above.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1690954 - Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame,spohl

As its background might not be themed.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9222127 [details]
Bug 1690954 - Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame,spohl

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial color change to match the text color of the <select>.
• String changes made/needed: none

Comment 4

[Pascal Chevrel:pascalc]

Comment on attachment 9222127 [details]
Bug 1690954 - Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame,spohl

Low risk and a fix for an issue that may become very visible as we are now shipping non-native form theming, approved for 89 beta 14 after it has landed on mozilla-central, thanks.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b01dc039dbc
Draw the menulist arrow button using currentColor rather than a fixed color. r=jfkthame

Comment 6

[Chris Peterson [:cpeterson]]

Low risk and a fix for an issue that may become very visible as we are now shipping non-native form theming, approved for 89 beta 14 after it has landed on mozilla-central, thanks.

In that case, setting Beta status-firefox89=affected.

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/7b01dc039dbc

Comment 8

[Daniel Bodea [:danibodea]]

This fix was reproduced and verified in Nightly v90.0a1, builds before and after the fix on WIndows 10, Mac OS 11.3.1 and Ubuntu 20. The arrow on the button is now showing the correct color.
Waiting for the fix to be uplifted.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/93268387eafd

Comment 10

[Daniel Bodea [:danibodea]]

Confirmed as fixed on Beta v89.0b14 on Windows 10, Mac OS 11.3.1 and Ubuntu 20.