1690970 - Stop using Services.prefs.deleteBranch

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

Because bug 1505941 exists, we shouldn't be using deleteBranch now that we have content processes. Here's all the uses we have: https://searchfox.org/comm-central/search?q=deletebranch&path=&case=false&regexp=false

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1690970 - Stop using Services.prefs.deleteBranch. r?mkmelin

I've decided not to change the test files as the bug only affects prefs that are used across restarts.

Comment 2

[Geoff Lankow (:darktrojan)]

Try: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=f7f02a12806c8ba8e2816e099780202a7c182bd9

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eff16c6d7e9f
Stop using Services.prefs.deleteBranch. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9201331 [details]
Bug 1690970 - Stop using Services.prefs.deleteBranch. r?mkmelin

[Approval Request Comment]
Regression caused by (bug #): bug 1505941 + tb-fission
User impact if declined: user accounts and calendars that get deleted become zombies and come back on restart
Testing completed (on c-c, etc.): just landed
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Geoff Lankow (:darktrojan)]

Comment on attachment 9201331 [details]
Bug 1690970 - Stop using Services.prefs.deleteBranch. r?mkmelin

Hold up, I broke something. :-/

Comment 6

[Geoff Lankow (:darktrojan)]

Backed out:
https://hg.mozilla.org/comm-central/rev/34e5fc23e071432f5b3235fcc6940b5e9db4e1e1

The way I fixed this was clearing too many preferences. I was clearing all prefs with names that started with foo, but I should only clear foo itself and those that start with foo..

Apparently I'm too blind to notice the test failure in my Try run.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/883139ef4ac9
Stop using Services.prefs.deleteBranch. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9201331 [details]
Bug 1690970 - Stop using Services.prefs.deleteBranch. r?mkmelin

Okay let's try that again.

[Approval Request Comment]
Regression caused by (bug #): bug 1505941 + tb-fission
User impact if declined: user accounts and calendars that get deleted become zombies and come back on restart
Testing completed (on c-c, etc.): landed yesterday
Risk to taking this patch (and alternatives if risky): low, but I said that last time ;-)

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9201331 [details]
Bug 1690970 - Stop using Services.prefs.deleteBranch. r?mkmelin

[Triage Comment]
Approved for beta

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 86.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/08e34e78093d