Closed Bug 1690971 Opened 4 years ago Closed 4 years ago

Incoming folder name overlays folder icon resulting in visual distortion when new mail arrives

Categories

(Thunderbird :: Theme, defect)

defect

Tracking

(thunderbird_esr78 unaffected, thunderbird86 wontfix, thunderbird87 affected)

RESOLVED FIXED
87 Branch
Tracking Status
thunderbird_esr78 --- unaffected
thunderbird86 --- wontfix
thunderbird87 --- affected

People

(Reporter: macuka2, Assigned: Paenglab)

Details

Attachments

(4 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

Anytime I receive a new mail into any account, the Folder list element, which turns blue and shows the number of unread mail turns unreadible.

Actual results:

The notification way somehow garbled it's location

Expected results:

Just turn blue and add the number of unread mail

Hi Andrass9, definitely your screenshot does look a bit garbled...! :-/
Unfortunately, I am failing to reproduce this on Win10, TB 78.7.0 (32-Bit) and TB Daily 87.0a1 (2021-02-03) (64-bit).
So there's something different on your side which we need to identify!

  • Please check if problem occurs after doing this?
    ≡ > Help > Restart with Add-ons Disabled…
  • Did you customize folder icon color?
  • Any other layout-related customizations (userchrome.css, themes etc.)?
  • Please report your TB version from Help > About Thunderbird
  • Please report your version of Windows.
Severity: -- → S4
Component: Folder and Message Lists → Theme
Flags: needinfo?(macuka2)
Summary: Mail accounts are is scrambled when new mail arrives → Incoming folder name overlays folder icon resulting in visual distortion when new mail arrives
Version: 8 Branch → unspecified

TB version is 86.0b1
I got the upgrade yesterday, I did not have this problem before.
I did not customize anything in TB
Windows 7 Pro 64 bits. 64GB memory, Core i7-5960X, Dual monitor 2x 1920x1200 GeForce GT 740
Restarted with Add-ons Disabled / no change.

Flags: needinfo?(macuka2)

Uh? I've never seen anything like this.
Richard, do you have any idea why this is happening?

Flags: needinfo?(richard.marti)

Maybe helps: It happens, when the given folder first time gets unread message. Stays, while new messages are coming (the number is increasing of course). When the wierd item is selected, it goes back to normal. If the account line has it and selected, it opens the underlying folders and all of which has new message inherits the strange view.
It happens only with the current update.

Attached patch 1690971-folder-issues.patch (obsolete) — Splinter Review

This happens on Windows 7 Classic and on all Windows High Contrast themes.

I fixed the text position and also the colours of the unread folder icons.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(richard.marti)
Attachment #9201507 - Flags: review?(bugzilla2007)

Excellent job, fixing it so fast! When it will be available, I will test it :)

Thanks!

Gentle review ping.

Updated to 86.0b3 - the bug still exists

Looks good to me - as good as HighContrast can get...

Comment on attachment 9201507 [details] [diff] [review] 1690971-folder-issues.patch Review of attachment 9201507 [details] [diff] [review]: ----------------------------------------------------------------- Thank you, Richard! Needles in the haystack, amazing! I'm not an expert on our CSS logic, but this does fix the problem and the colors must be right now! (see screenshot above) (That said, HighContrast - Left-Alt+Shift+Print - is an awful thing to test, so painful to the eye and slowing down my machine to a near halt.) Can't test Win7. Please change the commit message to: Bug 1690971 - On non-default Windows themes, fix unread folder color and folder label position with new messages. r=thomas8
Attachment #9201507 - Flags: review?(bugzilla2007) → review+

Should probably uplift this for the sake of Win7 users and those depending on HighContrast access.

Fixed commit message.

Attachment #9201507 - Attachment is obsolete: true
Attachment #9203351 - Flags: review+
Target Milestone: --- → 87 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/9ea35390695a
On non-default Windows themes, fix unread folder color and folder label position with new messages. r=thomas8

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9203351 [details] [diff] [review]
1690971-folder-issues.patch

[Approval Request Comment]
User impact if declined: overlapped text and icon when new message in folder on Windows Classic and High Contrast
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Attachment #9203351 - Flags: approval-comm-beta?

Comment on attachment 9203351 [details] [diff] [review]
1690971-folder-issues.patch

[Triage Comment]
this missed beta 86, but is in beta 87

Attachment #9203351 - Flags: approval-comm-beta? → approval-comm-beta-

This bug resurfaced with the Tb 90.0b1 update :(

Attached image Clipboard0190.0.jpg

The bug is back with the Tb 90.0b1 and the beta 2 too.

If it reproduces in safe mode, please file a new bug report.

Not needed, I'm doing it.

Filed bug 1717288.

Nice job! Fixed in 90.0b3 / Thanks!

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: