Closed Bug 1690977 Opened 8 months ago Closed 7 months ago

Support proxy in SmtpClient.jsm

Categories

(MailNews Core :: Networking: SMTP, task)

Tracking

(thunderbird_esr78 unaffected)

RESOLVED FIXED
87 Branch
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: rnons, Assigned: rnons)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

TCPSocket has worked well so far, but it doesn't support proxy (bug 902346). This task is to implement something similar to the TCPSocket interface with nsISocketTransport. SmtpClient.jsm itself doesn't need much change.

One alternative would also be to take on fixing bug 902346.

Depends on: 902346
Summary: Use nsISocketTransport instead of TCPSocket in SmtpClient.jsm → Support proxy in SmtpClient.jsm
Depends on: 1693680
Attached patch 1690977.patchSplinter Review
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
Attachment #9204134 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9204134 [details] [diff] [review]
1690977.patch

Review of attachment 9204134 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good. r=mkmelin
Attachment #9204134 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 87 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/299ebdad46b2
Enable test_smtpProxy for SmtpService.jsm. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.