Closed
Bug 1690977
Opened 4 years ago
Closed 4 years ago
Support proxy in SmtpClient.jsm
Categories
(MailNews Core :: Networking: SMTP, task)
MailNews Core
Networking: SMTP
Tracking
(thunderbird_esr78 unaffected)
RESOLVED
FIXED
87 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: rnons, Assigned: rnons)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
4.07 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
TCPSocket has worked well so far, but it doesn't support proxy (bug 902346). This task is to implement something similar to the TCPSocket interface with nsISocketTransport. SmtpClient.jsm itself doesn't need much change.
|
||
Comment 1•4 years ago
|
||
One alternative would also be to take on fixing bug 902346.
|
Assignee | |
Updated•4 years ago
|
Depends on: 902346
Summary: Use nsISocketTransport instead of TCPSocket in SmtpClient.jsm → Support proxy in SmtpClient.jsm
|
|
Assignee | |
Comment 2•4 years ago
|
||
Assignee: nobody → remotenonsense
Status: NEW → ASSIGNED
Attachment #9204134 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 3•4 years ago
|
||
Comment on attachment 9204134 [details] [diff] [review]
1690977.patch
Review of attachment 9204134 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, this looks good. r=mkmelin
Attachment #9204134 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Updated•4 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → 87 Branch
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/299ebdad46b2
Enable test_smtpProxy for SmtpService.jsm. r=mkmelin
|
|
||
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•