Closed Bug 1691075 Opened 5 years ago Closed 5 years ago

Fix "this is undefined" error in startup/worker.js

Categories

(DevTools :: Framework, defect, P1)

defect

Tracking

(firefox-esr78 unaffected, firefox85 unaffected, firefox86 wontfix, firefox87 fixed)

RESOLVED FIXED
87 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox85 --- unaffected
firefox86 --- wontfix
firefox87 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Steps to reproduce

  1. Open Firefox, navigate to https://www.google.com/
  2. Open the Browser Toolbox, select the console
  3. In Firefox, open the regular toolbox, select the debugger

Actual results

we get the following error:

console.error: (new TypeError("can't access property "addEventListener", this is undefined", "resource://devtools/server/startup/worker.js", 24))

originating from https://searchfox.org/mozilla-central/rev/40205f1b55f1ba8a26fcbd362c20d843e8718a87/devtools/server/startup/worker.js#24

this code isn't covered by test, and was modified in Bug 1681888, which probably caused the regression

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07fff08a9467 [devtools] Fix error in startup/worker.js. r=bomsy.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: