1681888 - Remove defer usage in devtools/server/startup/worker.js

Status: RESOLVED FIXED

(DevTools :: Shared Components, task, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

We should use new Promise instead.

Honza

Comment 1

[Falguni Islam]

Hello, I am new to contributing to Bugzilla can you assigned me to this issue so that I can learn to fix these bugs and also suggest to me how can Is start working on this bug to fix it.

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Done, thanks for helping!

Honza

Comment 3

[Falguni Islam]

Hello Honza, I am a bit confused how can i start working into this bug. I mean do this codes are in any git hub. For help in Mozilla chat channel how can i communicate about any kind of help regarding this bugs fixing issue.

Comment 4

[Tim Nguyen :ntim]

(In reply to Falguni Islam from comment #3)

Hello Honza, I am a bit confused how can i start working into this bug. I mean do this codes are in any git hub. For help in Mozilla chat channel how can i communicate about any kind of help regarding this bugs fixing issue.

See https://firefox-source-docs.mozilla.org/setup/contributing_code.html

Comment 5

[Falguni Islam]

Thank you very much, @Tim Nguyen. I had already understood how to setup. Currently, I am studying these bugs to fix them and working on these bugs.

Comment 6

[Tim Nguyen :ntim]

https://searchfox.org/mozilla-central/source/devtools/shared/defer.js shows how defer is implemented in general.

This bug is about rewriting devtools/server/startup/worker.js to not use the defer module.

If the promise property isn't used anywhere else:

  const deferred = defer();
  rpcDeferreds[id] = deferred;
  return deferred.promise;

can just be changed to:

  return new Promise((resolve, reject) => {
    rpcDeferreds[id] = { resolve, reject };
  });

If the promise property is used elsewhere (I'm not sure, but I don't think it is), you can just port the defer.js code inside the worker.js that uses it and adapt the code slightly.

Hopefully that's helpful, please let me know if you've got any questions.

Comment 7

[Falguni Islam]

Attachment: Bug 1681888 - [devtools] Remove defer usage in devtools/server/startup/worker.js. r=nchevobbe

Having problem to solve a error of break

Bug 168188 problem to understand the error Nicolas Silva <[e-mail]>

Bug 1681888 using my concept to use break Nicolas Silva <[e-mail]>

Comment 8

[Falguni Islam]

Hello @Tim Nguyen. , actually, this video helps me to submit my patches https://www.youtube.com/watch?v=3e-eaeeIDXk&t=509s but I am a bit confused that how can I land my revisions in Lando as in my Phabricator I did not found any lando. Is Lando important to use?

Comment 9

[Tim Nguyen :ntim]

(In reply to Falguni Islam from comment #8)

Hello @Tim Nguyen. , actually, this video helps me to submit my patches https://www.youtube.com/watch?v=3e-eaeeIDXk&t=509s but I am a bit confused that how can I land my revisions in Lando as in my Phabricator I did not found any lando. Is Lando important to use?

Lando needs special permissions, instead you should use request review and then use the "Check-in needed" tag on Phabricator after approval.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d875215ffaf6
[devtools] Remove defer usage in devtools/server/startup/worker.js. r=nchevobbe

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d875215ffaf6

Comment 12

[Falguni Islam]

Attachment: Bug 1681888 - Removed 'rpcDeferreds' is assigned a value but never used

Comment 13

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Falguni, this bug is already fixed, perhaps you wanted to attach the patch to different bug?

Honza

Comment 14

[Falguni Islam]

Hello Honza, Actually I was facing a problem while working on a bug. This file work was also attached in my new work , so I had separate this file and did hg revert , now my problem has been fixed.