1691219 - Preferences search suggestions child checkboxes don't enable/disable consistently

Status: NEW

(Firefox :: Search, defect, P4)

Description

[Jason Byrne]

Attachment: firefox_preferences_search_checkboxes_inconsistent.png

User Agent: Mozilla/5.0 (X11; Linux i686; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

Preferences -> Search
Scroll to Search Suggestions

Check/uncheck (parent) 'Provide search suggestions' checkbox

Actual results:

Checking/unchecking of child checkboxes under parent 'Provide search suggestions' checkbox is inconsistent.

The child checkboxes don't check/uncheck based on the status of the parent checkbox, and instead seem to 'remember' their previous settings, before the parent checkbox was checked/unchecked.

Also, the 'Show search suggestions ahead of browsing history in address bar results' checkbox doesn't check/uncheck based on the parent checkbox, and instead seems to be dependent on the 'Show search suggestions in address bar results' above it'

Expected results:

Child checkboxes should have consistent checked/unchecked status, based on the status of the parent checkbox.

Also, if the 'Show search suggestions ahead of browsing history in address bar results' checkbox' is dependent upon the status of the 'Show search suggestions in address bar results' checkbox, then the placement of the 'Show search suggestions ahead of browsing history in address bar results' checkbox' checkbox should be moved to reflect a parent/child dependency with the 'Show search suggestions in address bar results' above it.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Preferences' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[:Gijs (he/him)]

I'm assuming the search team has ideas about what the correct behaviour here is supposed to be, so moving this bug there so they can triage accordingly. As noted in bug 1691218 and bug 1691217, I don't think we should necessarily always check/uncheck based on the "parent" checkbox.

Comment 3

[Dale Harvey (:daleharvey)]

As Gijs says these arent strict subsets so we shouldnt auto toggle, this is quite confusing though and this area of preferences is having work done at the moment so hopefuly can close it out while the redesign addresses it

Comment 4

[Florencia Di Ciocco, NI to vbalducci]

Hi,

I agree that this behavior is somewhat confusing. I want to also add that when all children checkboxes are checked, the father checkbox is not checked.
Dale mentioned that this bug can be closed, but I'll add myself as CC in case you need some QA testing.