1691285 - tag and 'mailing lists' list in global search has scrollbar because 'None' label is missing

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: screenshot of tag list with scrollbar

The tag list in the global search sidebar has a scrollbar because the 'None' label is missing.

Steps to reproduce:

1. Tag several message: Select message, press a number 1-5 (forces the tag selector in the global search to be shown).
2. Click "Get Messages" button at top left (rebuilds search database with the tags).
3. In the global search bar, search e.g. for the host of your email.

Actual result:
Tag list in sidebar of search results has scrollbar because 'None' tag for messages without tags is missing.

Expected result:
'None' tag shown + no scroll bar.

This is from bug 1637136. ariasuni, do you want to investigate?

Comment 1

[ariasuni]

Attachment: Bug 1691285 - fix some labels having no text in global search

Comment 2

[ariasuni]

The problem seems kind of obvious now that I review my code from 5 months ago. The patch worked at the time because there wasn’t the new translations yet, but now the bug appears. I made a patch and tested that it fixes the problem.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/caf1d9b64a90
fix some labels having no text in global search. r=mkmelin