Closed Bug 1691310 Opened 3 years ago Closed 3 years ago

Remove allowEvents DOM property from XULElement

Categories

(Core :: XUL, task)

task

Tracking

()

RESOLVED FIXED
87 Branch
Tracking Status
firefox87 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is only about removing the DOM property, not the attribute.

Neither TB or Firefox use it.

Platform code also already reads directly the attribute value.

(Also, there's only one usage of the attribute in m-c, so I suspect encouraging the use isn't great: https://searchfox.org/mozilla-central/search?q=allowevents&path=&case=false&regexp=false)

Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED

https://searchfox.org/comm-central/search?q=.allowEvents&path=&case=false&regexp=false

Turns out I was wrong about TB. There are a few usages. Here are how to convert them:

if (X.allowEvents) -> `if (X.getAttribute("allowevents") === "true")

X.allowEvents = true; -> X.setAttribute("allowevents", "true");

X.allowEvents = false; -> X.removeAttribute("allowevents");

(Note that toggleAttribute() doesn't work here, because platform code specifically checks for equality to "true")

Flags: needinfo?(mkmelin+mozilla)
See Also: → 1691332

Will take care of it in bug 1691332.

Flags: needinfo?(mkmelin+mozilla)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/76e42300d478
Remove allowEvents DOM property from XULElement. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: