1691310 - Remove allowEvents DOM property from XULElement

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Tim Nguyen :ntim]

This is only about removing the DOM property, not the attribute.

Neither TB or Firefox use it.

Platform code also already reads directly the attribute value.

Comment 1

[Tim Nguyen :ntim]

(Also, there's only one usage of the attribute in m-c, so I suspect encouraging the use isn't great: https://searchfox.org/mozilla-central/search?q=allowevents&path=&case=false&regexp=false)

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1691310 - Remove allowEvents DOM property from XULElement. r=emilio

Comment 3

[Tim Nguyen :ntim]

https://searchfox.org/comm-central/search?q=.allowEvents&path=&case=false&regexp=false

Turns out I was wrong about TB. There are a few usages. Here are how to convert them:

if (X.allowEvents) -> `if (X.getAttribute("allowevents") === "true")

X.allowEvents = true; -> X.setAttribute("allowevents", "true");

X.allowEvents = false; -> X.removeAttribute("allowevents");

(Note that toggleAttribute() doesn't work here, because platform code specifically checks for equality to "true")

Comment 4

[Magnus Melin [:mkmelin]]

Will take care of it in bug 1691332.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76e42300d478
Remove allowEvents DOM property from XULElement. r=emilio

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/76e42300d478