1691332 - Port bug 1691310: Remove allowEvents DOM property from XULElement

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, task)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #1691310 +++

This is only about removing the DOM property, not the attribute.

https://searchfox.org/comm-central/search?q=.allowevents&path=&case=false&regexp=false

Bug 1691310 comment 3 has info about the conversion.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1691332_rm_allowEvents.patch

Comment 2

[Tim Nguyen :ntim]

Comment on attachment 9201719 [details] [diff] [review]
bug1691332_rm_allowEvents.patch

Review of attachment 9201719 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/test/browser/newmailaccount/browser_newmailaccount.js
@@ +895,5 @@
>    let newMailAccountMenuitem = mc.eid("newMailAccountMenuItem");
>  
>    // First, we do some hackery to allow the "New" menupopup to respond to
>    // events...
> +  let oldAllowEvents = newMenuPopup.getNode().getAttribute("allowevents");

You want to check equality with `"true"` here as well.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: bug1691332_rm_allowEvents.patch

Updated, thx!

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 9201758 [details] [diff] [review]
bug1691332_rm_allowEvents.patch

Review of attachment 9201758 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good overall.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8cf27842256d
Port bug 1691310: Remove allowEvents DOM property from XULElement. r=