1691314 - Rewrite `X.setAttribute("hidden", Y)` to `X.hidden = Y` in devtools/client

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Tim Nguyen :ntim]

+++ This bug was initially created as a clone of Bug #1691274 +++

https://searchfox.org/mozilla-central/search?q=.setAttribute%28%22hidden%22&path=devtools%2Fclient&case=false&regexp=false

.setAttribute("hidden", "true"); -> .hidden = true;
.setAttribute("hidden", true); -> .hidden = true;

.setAttribute("hidden", "false"); -> .hidden = false;
.setAttribute("hidden", false); -> .hidden = false;

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1691314 - Use DOM hidden property instead of attribute methods in devtools/client. r=nchevobbe

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2d82e87b557
Use DOM hidden property instead of attribute methods in devtools/client. r=nchevobbe

Comment 3

[Atila Butkovits]

Backed out for causing failures on browser_styleeditor_copyurl.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/85ad75cdd7fdae48cd0fd7755bcd0a2e4f5eae76

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=YNM8xYQ5R2-HUnNzHTVYdw.0&revision=b2d82e87b5575e7ef422a8b920436db0889c1191&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-devtools-chrome-e10s%2Cdt5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=329371606&repo=autoland&lineNumber=7165

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4761c80b4305
Use DOM hidden property instead of attribute methods in devtools/client. r=nchevobbe

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4761c80b4305