1691408 - Better telemetry for TRR confirmation

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

The number 1 reason we skip TRR is that confirmation is not finished.
We need to record some event telemetry containing the causes and results of trying to perform a confirmation.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1691408 - Add trrConfirmation event telemetry r=nhnt11!,dragana!

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: confirmation_event_telemetry_request.md

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9202040 [details]
confirmation_event_telemetry_request.md

lgtm if the network ID is calculated the same way as the other telemetry

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Valentin.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1, technical data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

No.

9. Does the data collection use a third-party collection tool?

No.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1691408 - Move DNS_TRR_NS_VERFIFIED2 accumulation out of conditional block r=#necko

Depends on D104509

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1691408 - Record confirmation event telemetry r=dragana!,nhnt11

• Adds new TRR* argument to CompleteLookup so we can extract the channel
  status from the TRR request.
• Record event whenever the confirmation context changes
• NetworkID is recorded whenever we start a new confirmation attempt
• Captive portal status is updated based on observer notifications
• We keep a buffer of the last 32 confirmation results.

Depends on D105172

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/512c5f7dc3de
Add trrConfirmation event telemetry r=nhnt11,dragana
https://hg.mozilla.org/integration/autoland/rev/2d1f833d0bd7
Move DNS_TRR_NS_VERFIFIED2 accumulation out of conditional block r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/bcd776feca32
Record confirmation event telemetry r=nhnt11,dragana,necko-reviewers

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/512c5f7dc3de
https://hg.mozilla.org/mozilla-central/rev/2d1f833d0bd7
https://hg.mozilla.org/mozilla-central/rev/bcd776feca32