1694949 - Add event telemetry containing failure reasons that lead to TRR confirmation failure

Status: RESOLVED FIXED

(Core :: Networking: DNS, enhancement, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

In Bug 1691408 we added some code that tracks the confirmation process. We know that a lot of times this happens because of multiple TRR failures in a row, but we don't know what caused those failures.

This bug is meant to record telemetry regarding those failures.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1694949 - Add event telemetry containing failure reasons that lead to TRR confirmation failure r=nhnt11,dragana

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: request-1694949.md

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9206117 [details]
request-1694949.md

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Valentin will monitor it.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1, technical data.

5. Is the data collection request for default-on or default-off?

-On.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

No.

9. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f62e7b312fa6
Add event telemetry containing failure reasons that lead to TRR confirmation failure r=nhnt11,dragana,necko-reviewers

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f62e7b312fa6

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9205697 [details]
Bug 1694949 - Add event telemetry containing failure reasons that lead to TRR confirmation failure r=nhnt11,dragana

Beta/Release Uplift Approval Request

• User impact if declined: Not user visible.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds an extra string to the telemetry event containing a string representation of the failure reasons that trigger a TRR confirmation. This is necessary to evaluate if our confirmation process is optimal.
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9205697 [details]
Bug 1694949 - Add event telemetry containing failure reasons that lead to TRR confirmation failure r=nhnt11,dragana

approved for 87.0b6

Comment 8

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-beta/rev/2ae52270f093