1691474 - Provide alternative Add Search Engine access out of the Page actions menu

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Striemer [:mstriemer]]

With the Page actions (meatball) menu being removed, the Add Search Engine button will need to be moved elsewhere.

Comment 1

[Harry Twyford]

From today's Proton UX->Engineering handoff meeting, we decided that we will show the Add Engine icon at the end of the search shortcuts in the Urlbar. So the workflow to add an OpenSearch engine is

1. Open a page that offers an OpenSearch engine.
2. Click the address bar to open the results panel.
3. Click the Add Search Engine icon at the bottom of the results panel (the engine's icon is a green "+" badge).

Some users disable Top Sites in the address bar, and so step 2 won't work for them. To serve those users, we will also add a "Add Search Engine" (copy not final) item to the Urlbar context menu when the user is on a page that offers an OpenSearch engine.

Comment 2

[Karl Dubost💡 :karlcow]

As a note the current error message is confusing for this menu and maybe that should be a separate issue.
See https://github.com/webcompat/web-bugs/issues/66623

Comment 3

[Mark Banner (:standard8)]

(In reply to Karl Dubost💡 :karlcow from comment #2)

As a note the current error message is confusing for this menu and maybe that should be a separate issue.
See https://github.com/webcompat/web-bugs/issues/66623

I'm not sure there's too much that can be done to improve that, without going into technical details. We do have bug 343829 on adding logging to the console, but if there's a suggestion please file a new bug.

Note also that specific issue is filed as bug 1692189. Not quite sure what it is yet, but probably Google translate specific.

Comment 4

[Marco Bonardo [:mak]]

I splitted the contextual menu to Bug 1696752, I still have to work on the shortcut buttons. The plan is to show up to 3 engines in the shortcut buttons area. In the rare case the page provides more than 3 engines, they can be installed from the contextual menu, that supports a sub-menu in such case. But even in the worst case with Bug 1696752 in we already have an alternative way to add engines without the PageActions menu.

Comment 5

[Marco Bonardo [:mak]]

Attachment: Bug 1691474 - Allow to add search engines from the shortcut buttons in the Address Bar. r=harry

Comment 6

[Marco Bonardo [:mak]]

Note, I'm not removing the original button here, since I think we'll do it for all the actions elsewhere, likely bug 1697191.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93ee3cbdeb41
Allow to add search engines from the shortcut buttons in the Address Bar. r=harry

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/93ee3cbdeb41

Comment 9

[Pablo]

Hi Harry

Im checking themes on latest nightly and noticed that Using the Default theme i can see the option on the context menu, but as soon as i changed it to light theme, the context menu option for adding search engine went missing. I checked it on windows10 and MacOs 10.15 and happened the same.

Comment 10

[Marco Bonardo [:mak]]

That may actually be due to a GC issue that I'm fixing in bug 1698692. Could you please check once that is merged?

Comment 11

[Pablo]

Sure, i will check
thanks

Comment 12

[Pablo]

Hi Marco, i checked again using todays nightly on windows10 and when changing the theme for example i changed to light mode, the add search engine from the address bar on right click is not visible anymore. Do you want me to open a new bug for it?

Comment 13

[Marco Bonardo [:mak]]

yes please file a new bug assigned to me, there must be something missing yet and I want to investigate it.

Comment 14

[Pablo]

Done marco, opened bug https://bugzilla.mozilla.org/show_bug.cgi?id=1700137

Comment 15

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

We verified this issue using Fx 88.0b5 on Windows 10 x64, macOS 10.13 and Ubuntu 18.04 LTS.