1691495 - Add policy/policies for `app.update.background.enabled`

Status: RESOLVED FIXED

(Toolkit :: Application Update, task)

Description

[Nick Alexander :nalexander [he/him]]

The per-installation pref app.update.auto is controlled by AppAutoUpdate. We need a pref for app.update.background.enabled.

This is essentially Bug 1657533 but for app.update.background.enabled.

Comment 1

[Kirk Steuber (he/him) [:bytesized]]

I'll be working on this bug. I just clarified with :nalexander that the pref/policy won't initially be hooked up to anything. So I'll make sure to write a test, which will be its only consumer for now.

Comment 2

[Kirk Steuber (he/him) [:bytesized]]

Attachment: Bug 1691495 - Add an enterprise policy to disable background application update r=nalexander!,mkaply!,#fluent-reviewers!

Comment 3

[Kirk Steuber (he/him) [:bytesized]]

Attachment: Bug 1691495 - Add per-installation pref: app.update.background.enabled r=nalexander!

Also moves appUpdateSettingIsLocked into UpdateUtils so it can be used by consumers.

Depends on D107921

Comment 4

[Kirk Steuber (he/him) [:bytesized]]

Attachment: Bug 1691495 - Add tests for app.update.background.enabled and its policy r=nalexander!,mkaply!

Note that I made this a browser test rather than an xpcshell test, despite not using any particular browser functionality. I made this choice because I expect to expand this test a bit later, adding checking for preferences UI, much like the browser_policy_app_auto_update.js test in the same directory does.

Depends on D107922

Comment 5

[Mike Kaply [:mkaply]]

How is the background updater going to read this?

Comment 6

[Kirk Steuber (he/him) [:bytesized]]

The newest iteration of the background update agent is headless Firefox, so it will read it the exact same way that the included test reads it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a5ce6145f08
Add an enterprise policy to disable background application update r=nalexander,mkaply,fluent-reviewers
https://hg.mozilla.org/integration/autoland/rev/1f6f64fb9699
Add per-installation pref: app.update.background.enabled r=nalexander
https://hg.mozilla.org/integration/autoland/rev/01c65f9b8d24
Add tests for app.update.background.enabled and its policy r=nalexander,mkaply

Comment 8

[Sandor Molnar]

https://hg.mozilla.org/mozilla-central/rev/5a5ce6145f08
https://hg.mozilla.org/mozilla-central/rev/1f6f64fb9699
https://hg.mozilla.org/mozilla-central/rev/01c65f9b8d24

Comment 9

[Nick Alexander :nalexander [he/him]]

I've filed https://github.com/mozilla/policy-templates/issues/756 to document this.