Closed Bug 1691518 Opened 3 years ago Closed 3 years ago

Remove v1 personalization from newtab

Categories

(Firefox :: Pocket, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
92 Branch
Iteration:
87.2 - Feb 8 - Feb 21
Tracking Status
firefox92 --- fixed

People

(Reporter: thecount, Assigned: thecount)

References

Details

Attachments

(1 file)

We're fully migrating to v2 of personalization, and we have the ability to remote turn off v2 if we see something funny in our pacing of stories.

But we're also at a point where if we turned off v2 remotely, we wouldn't want to revert to v1, but would instead revert to no personalization until we turned v2 back on.

So for the above reasons, we can remove v1 from the code completely, and reduce complexity in the code.

Depends on: 1691226
Assignee: nobody → sdowne
Iteration: --- → 87.2 - Feb 8 - Feb 21
Priority: -- → P1

To test:
Setup:

  1. Make a new profile.
  2. Ensure you can see spocs.
  3. Enable newtab devtools by flipping browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to true

Do some generic regression testing, making sure newtab loads and looks ok and basic functionality is there, and that spocs are showing fine.

Make sure personalization works:

  1. Go to about:newtab#devtools-ds
  2. Click on the buttons, in this order, with roughly 5 seconds between each click: "refresh cache", "expire cache", "trigger idle daily", and "trigger system tick"
  3. Refresh
  4. Scroll down to "Personalization" section of devtools.

Expected: Should see personalization section with enabled with a checkbox. A personalization initialized: true, and a personalization last updated with a data or time.

Check personalization turns off:

  1. Go to about:newtab#devtools-ds
  2. Scroll down to the personalization section.
  3. Uncheck personalization checkbox in personalization section.
  4. Restart.
  5. Scroll back to personalized section.

Expected: Personalization checkbox should still be off, and Personalization Last Updated should show (no data) and Personalization Initialized should be false.

Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/278f815cc8a2
Remove v1 personalization from newtab r=gvn
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: