Handle thread actor reconfigure options using the watcher Configuration actor
Categories
(DevTools :: Framework, task, P3)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Unassigned)
References
Details
In Bug 1690698, we introduce a new Configuration actor that will be used to propagate devtools settings from the client to the server.
We will start using it for the browsing-context target options passed via the reconfigure helper.
The thread actor also has a reconfigure method and supports a set of options:
- ignoreCaughtExceptions
- logEventBreakpoints
- observeAsmJS
- pauseWorkersUntilAttach
- pauseOnExceptions
- shouldIncludeAsyncLiveFrames
- shouldIncludeSavedFrames
- shouldShowOverlay
- skipBreakpoints
There is also breakpoints and eventBreakpoints although I am not sure what is there role compare to breakpoints set via the regular setBreakpoint APIs.
|
||
Comment 1•4 years ago
|
||
I was aiming to tackle most of these flags via bug 1687261.
With explicit methods on explicit actors. Like setBreakpoint on BreakpointListActor.
I planned that based on your original feedback for breakpoints.
Do not expose addWatcherDataEntry straight to the client and instead use explicit method for each data entry.
It looks like your circle back to this original proposal, but with a different naming.
Should we pass all data that is useful across navigation via the configuration actor ?
If not, what is the definition of what is a config versus what shouldn't be a config?
If yes, should we get rid of BreakpointListActor and replace it by a configuration?
Also, if yes:
- all server side events would be resources,
- all permanent actions would be configs,
- only transcient actions and on-demand data fetching would require custom methods
Description
•