1691878 - modify gfx/layers/apz/test/mochitest/helper_scrollframe_activation_on_load.html and test_layerization.html so they better test the activate all scroll frames code better

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

In bug 1690433 we created code to activate all scroll frames, but deferred modifying these tests to more fully test this new code.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1691878. Modify gfx/layers/apz/test/mochitest/test_layerization.html to test the activate all scroll frames code better. r?botond

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1691878. Modify gfx/layers/apz/test/mochitest/helper_scrollframe_activation_on_load.html to test the activate all scroll frames code better. r?botond

Depends on D104656

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5deab976ee9e
Modify gfx/layers/apz/test/mochitest/helper_scrollframe_activation_on_load.html to test the activate all scroll frames code better. r=botond

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5deab976ee9e

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1691878. Make test_layerization.html wait for the wheel events it sends and then paints instead of waiting for scroll events and no paints. r?botond

The waitForScroll argument to promiseMoveMouseAndScrollWheelOver determines if we wait for a scroll event (if waitForScroll is true) or a wheel event (if waitForScroll is false). That might not be clear just from looking at it (where one might assume waitForScroll = false means no waiting at all).

In all cases but one in this test we wait for the scroll event.

When activateAllScrollFrames = false I guess this is enough to guarantee that any new metrics have been sent in a transaction. But it is not with activateAllScrollFrames = true for two reasons.

The first is that apz can handle the wheel event for any scroll frame immediately, it will send a repaint request to content which will scroll and send a scroll event. Content can then handle that scroll event without even sending it's current metrics in a transaction. So we need to wait for paints to be flushed.

But even that is not enough because we can wait for a paint but in several cases we need a minimal display port to be cleared to be full display port and that happens in PrepareForSetTargetAPZCNotification, which only happens after content gets the wheel event, which can happen after apz gets the wheel event, and after content gets the scroll event, and after content gets the scroll event and paints.

So we need to wait for the wheel event to rearch content and then wait for paints.

Depends on D104656

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1691878. Make one bit of test_layerization.html loop until it passes. r?botond

The comment in the test should explain.

Depends on D105407

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69d59541611a
Modify gfx/layers/apz/test/mochitest/test_layerization.html to test the activate all scroll frames code better. r=botond
https://hg.mozilla.org/integration/autoland/rev/bd7df680fbe4
Make test_layerization.html wait for the wheel events it sends and then paints instead of waiting for scroll events and no paints. r=botond
https://hg.mozilla.org/integration/autoland/rev/bdf3cad16bb4
Make one bit of test_layerization.html loop until it passes. r=botond

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5ded5d1b5fa
Fix eslint failure a=lint-fix CLOSED TREE

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6236320fabcc
Fix lint failure. a=lin-fix CLOSED TREE DONTBUILD

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/69d59541611a
https://hg.mozilla.org/mozilla-central/rev/bd7df680fbe4
https://hg.mozilla.org/mozilla-central/rev/bdf3cad16bb4
https://hg.mozilla.org/mozilla-central/rev/b5ded5d1b5fa
https://hg.mozilla.org/mozilla-central/rev/6236320fabcc