1691879 - fix expiry with minimal display ports

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Timothy Nikkel (:tnikkel)]

In RemoveDisplayPortCallback

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/layout/generic/nsGfxScrollFrame.cpp#2588

we don't remove a regular display port and instill a minimal display port if mIsScrollParent is true on the scroll frame. mIsScrollParent gets set to true if any child scroll frame has a display port of any time (minimal or otherwise).

We want to expire a regular display port and replace it with a minimal display port if it only contains minimal display ports (or no display ports).

This was caught while I was updating gfx/layers/apz/test/mochitest/test_layerization.html for the new activate all scroll frames code (bug 1691878).

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1691879. Fix expiry with minimal display ports. r?botond

In RemoveDisplayPortCallback

https://searchfox.org/mozilla-central/rev/7067bbd8194f4346ec59d77c33cd88f06763e090/layout/generic/nsGfxScrollFrame.cpp#2588

we don't remove a regular display port and instill a minimal display port if mIsScrollParent is true on the scroll frame. mIsScrollParent gets set to true if any child scroll frame has a display port of any time (minimal or otherwise).

We want to expire a regular display port and replace it with a minimal display port if it only contains minimal display ports (or no display ports).

This was caught while I was updating gfx/layers/apz/test/mochitest/test_layerization.html for the new activate all scroll frames code (bug 1691878).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1690433

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a0b3e09ce14
Fix expiry with minimal display ports. r=botond

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/8a0b3e09ce14