Closed Bug 1692021 Opened 10 months ago Closed 8 months ago

Update notification bar stacking

Categories

(Firefox :: Messaging System, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
89 Branch
Tracking Status
firefox89 --- verified

People

(Reporter: mstriemer, Assigned: mstriemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-infobars] [priority:2a])

Attachments

(1 file)

With the proton changes, notification bars will now always be shown, rather than just showing the highest-priority notification in each of the 3 notification boxes.

All browser-specific notifications will go in one notificationbox (rather than in gHighPriorityNotificationBox and gNotificationBox). This notificationbox will be above the tab-specific notificationbox, and new notifications are added at the top of the notificationbox.

All tab-specific notifications will be shown, with the newest notification at the bottom of the notificationbox.

So with 4 notifications shown (this seems incredibly unlikely but preparing for the worst) with the number being order of appearance:

4) Places locked
1) Set as default
------------------
2) Pop-up blocked
3) Part of page crashed
Whiteboard: [proton-infobars] → [proton-infobars] [priority:2a]

Has this been completed? It appears that not everything is 100%, but that stacking functions from my PM review.

Flags: needinfo?(mstriemer)
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Flags: needinfo?(mstriemer)
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b80da7156f20
Order infobars by appearnce rather than priority r=Gijs

Backed out for failures on test_notificationbox.xhtml

backout: https://hg.mozilla.org/integration/autoland/rev/e8ccb5d14184d1088712de5ce8037148649b8fdc

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=b80da7156f2018ea3c9bc5fb00c847a6e1a0f38f&searchStr=mochitest-chrome&group_state=expanded&selectedTaskRun=Qtog0aLGRq-NVQp-QqOZhg.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=336702332&repo=autoland&lineNumber=2704

[task 2021-04-15T20:29:36.482Z] 20:29:36 INFO - TEST-PASS | toolkit/content/tests/chrome/test_notificationbox.xhtml | removeAllNotifications
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - Buffered messages finished
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/chrome/test_notificationbox.xhtml | appendNotification last notification - got [object HTMLElement], expected [object HTMLElement]
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:500:14
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - result@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xhtml:419:9
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - runTimedTests@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xhtml:605:22
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - runTimedTestsWait@chrome://mochitests/content/chrome/toolkit/content/tests/chrome/test_notificationbox.xhtml:624:18
[task 2021-04-15T20:29:36.483Z] 20:29:36 INFO - Not taking screenshot here: see the one that was previously logged

Flags: needinfo?(mstriemer)
Attachment #9216163 - Attachment description: Bug 1692021 - Order infobars by appearnce rather than priority r?gijs → Bug 1692021 - Order infobars by appearance rather than priority r?gijs
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ad69409f8f4
Order infobars by appearance rather than priority r=Gijs
Flags: needinfo?(mstriemer)
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch

Verified fixed on Windows 10, MacOS 11 and Ubuntu 20.04 using Nightly 89.0a1 (20210418213620)

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.