1692046 - Add Proton address bar dark mode colours

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P2)

Comment 1

[Harry Twyford]

Attachment: Bug 1692046 - Add dark mode address bar and arrowpanel-border colors (Proton). r?mak,#desktop-theme-reviewers

There are a few things happening in this patch:

1. New colours are defined in proton-dark/manifest.json. This will be merged with dark/manifest.json when Proton is ready.
2. I removed specific rules for [lwt-default-theme-in-dark-mode]. The current plan is to merge proton-dark/manifest.json with default-theme/manifest.json when Proton is ready.
3. Two different borders can now be set on the Urlbar: toolbar_field_focus_border when the panel is closed, and popup_border when it is open. This is a behaviour change, but it's actually consistent with the documentation.
4. popup_border/arrowpanel-border-color is now transparent on non-LWT non-Linux non-HCM. This affects other panels, but I verified with UX on Slack that all light mode Proton panels are losing their border in favour of drop-shadows. These colours are set in browser-custom-colors which is a new sheet that will set Proton's saturated colours. I also moved some rules to that sheet from urlbarView.inc.css that were serving the same purpose.
5. A border is now shown around the searchbar popup. We never set a border-width on it! We were setting border-color so I don't know if this was intentional or just a bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d54f1666473a
Add dark mode address bar and arrowpanel-border colors (Proton). r=mak,dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b92cf73f3416
Fix lint issue. r=fix CLOSED TREE

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d54f1666473a
https://hg.mozilla.org/mozilla-central/rev/b92cf73f3416

Comment 5

[Adrian Florinescu [:aflorinescu]]

To confirm I understand correctly comment1 points 4 and 5:
in high contrast modes(w10 + ubuntu) combined with the default themes(default, dark, alpenglow), there should be a border for the expanded address bar, excluding light theme, for which there shouldn't be a border, just a drop-shadow ?

Comment 6

[Marco Bonardo [:mak]]

That sounds a lot like bug 1701200, it doesn't have an answer yet. Based on what landed here, the answer is yes, whether that is what we want is unclear, bur I'd assume high contrast wants a border.

Comment 7

[Harry Twyford]

I agree with Marco. We want a border in HCM on the default theme. It's expected that Light mode doesn't have a border, because in that case the user opted in to Light mode styling/colours.

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

This has been extensively covered for the pre-release sign off.
Marking the issue as verified fixed on Firefox 89.0b15 using Windows 10, Ubuntu and macOS 10.15.