1699821 - No border is shown in "search Toolbar"

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Pablo]

Attachment: borderubuntu.jpg

Description
Borders missing in "search bar in toolbar"

Tested on
Windows10 64bit : Reproducible only on left side
Ubuntu 20 : Reproducible on ALL Sides
macos 10.14 : Not reproducible.

Firefox Release 86.0.1 not reproducible
Firefox beta 87.0 not reproducible
Firefox Nightly 88.0a1 reproducible

** This is without proton, since on nightly proton is off by default**

Steps

• go to about:preferences#search
• enable Add search bar in toolbar
• type anything in searchbar in toolbar
• check the border

actual results
On windows10 the left border is missing, On ubuntu ALL BORDERS ARE MISSING.

expected results
borders should be visible.

Comment 1

[Pablo]

Attachment: windows10border.jpg

Comment 2

[Pablo]

last screenshot is from windows10

Comment 3

[Pablo]

This is without proton, since on nightly proton is off by default.

Comment 4

[Marco Bonardo [:mak]]

[Tracking Requested - why for this release]: visual regression

Comment 5

[Marco Bonardo [:mak]]

I suspect https://hg.mozilla.org/mozilla-central/rev/d54f1666473acafb01bbcb6d50846a8cf6a379d2 that unset border-width on non-proton

Comment 6

[Pablo]

This is the mozregression done with windows10

build info

build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/VMJbiXw4QiWHXzjlBU_cNw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: 7251d2406edd9343c1803c837a634a829d0a06d1
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d0238d81621ef6c0377b7328e71bf7c7ce8a610f&tochange=7251d2406edd9343c1803c837a634a829d0a06d1
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: VMJbiXw4QiWHXzjlBU_cNw

Log
Bug 1692046 - Add dark mode address bar and arrowpanel-border colors (Proton). r=mak,dao

Comment 7

[Harry Twyford]

Attachment: Bug 1699821 - Restore border to standalone search bar. r?mak!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8fb8e5b38ed
Restore border to standalone search bar. r=mak

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c8fb8e5b38ed

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 11

[Harry Twyford]

Comment on attachment 9210768 [details]
Bug 1699821 - Restore border to standalone search bar. r?mak!

Beta/Release Uplift Approval Request

• User impact if declined: Visual regression in non-Proton 88.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small CSS-only patch.
• String changes made/needed:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9210768 [details]
Bug 1699821 - Restore border to standalone search bar. r?mak!

Approved for 88.0b3.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2f43f5c4e07a

Comment 14

[Rares Doghi, Desktop QA]

This issue is verified as fixed on Ubuntu 20.04 and Windows 10 with Beta 88.0b3 and our latest Nightly build 89.0a1 (2021-03-26).