1692082 - Fix checkbox and radio menuitem styling

Status: RESOLVED FIXED

(Toolkit :: Themes, defect, P2)

Description

[Molly Howell (she/her) (mostly inactive)]

Checkboxes and radio buttons embedded in menus look pretty rough. We turned off the native style in bug 1682522 and replaced it with a generic checkmark icon (for both types of controls, which I honestly think might be fine), but it still needs more work to be presentable.

Comment 2

[:Gijs (he/him)]

I filed a JIRA ticket for this because there's no design for this.

Comment 3

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #2)

I filed a JIRA ticket for this because there's no design for this.

FWIW, this isn't the JIRA that corresponds to this ticket, but https://jira.mozilla.com/browse/FIDEFE-245 .

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://jira.mozilla.com/browse/FIDEFE-245 has been updated with the spec and icons to use.

Comment 5

[Dão Gottwald [:dao]]

The spec seems tricky to implement in a way that won't lead to inconsistencies. We may have to always add leading padding to menuitems (this would be standard Windows behavior) or disable the new styling entirely if nobody picks this up in time.

Comment 6

[:Gijs (he/him)]

Attachment: Bug 1692082 - fix spacing, icons and colours for checkmarks and arrows in Windows 10 menus, r?jaws

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fbbdd2195e1
fix spacing, icons and colours for checkmarks and arrows in Windows 10 menus, r=jaws

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6fbbdd2195e1