1692159 - Autofill Logins and passwords not working [maybe related to strange Enterprise Policies behaviour]

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[oneofthedamons]

Attachment: Capture_about_preferences_privacy.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

The Enterprises Policies issue reported at https://support.mozilla.org/en-US/questions/1325482 may be related.

The "Autofill logins and passwords" preference is no longer being honoured.

Actual results:

Login forms which have entries in the unlocked Password Manager are not being auto-filled. They used to be autofilled, prior to the following Enterprise Policies being activated:

DisableFirefoxAccounts [true]
PasswordManagerEnabled [false]
OfferToSaveLogins [false]
OfferToSaveLoginsDefault [false]

Even after the first 2 Enterprise Policies being removed, the behaviour continues with only these Enterprise Policies being shown active:

OfferToSaveLogins [false]
OfferToSaveLoginsDefault [false]

Expected results:

Login fields matching entries in the Password Manager should be auto-filled.

Comment 1

[oneofthedamons]

Attachment: Capture_about_policies_active.PNG

Comment 2

[oneofthedamons]

Attachment: Capture_about_policies_errors.PNG

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Enterprise Policies' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 4

[Mike Kaply [:mkaply]]

Are you sure we used to autofill passwords in that case? I think of OfferToSaveLogins is false, we don't offer and we don't autofill. I'll run some tests.

If you're sure this behavior is changed, can you see if you can use https://mozilla.github.io/mozregression/ to figure out when it changed?

Comment 5

[oneofthedamons]

Sorry, I conflated 2 issues with this bug submission, one of which was not a bug at all but my mistake.

It would appear setting OfferToSaveLogins prevents autofill. If this is expected behaviour then I’ll close the bug, but from my perspective I feel this might be documented better?

In https://github.com/mozilla/policy-templates#offertosavelogins the description is simply: “Control whether or not Firefox offers to save passwords.”

Comment 6

[Marcela (Please NI request to Brindusa Tot)]

Hi Mike!
Could you confirm if what the reporter indicates in comment 5 is the expected behavior? If so, could the issue be closed?

Comment 7

[Marcela (Please NI request to Brindusa Tot)]

Hi!
I think it might be an intended behavior and I will close this issue as Invalid. Mike if you consider it a valid issue please feel free to reopen it.

Comment 8

[Mike Kaply [:mkaply]]

That is the expected behavior. I'm updating the docs. Sorry for taking so long.

Comment 9

[Mike Kaply [:mkaply]]

OK, I get this now and it's a bug in preferences.

If you set OfferToSaveLogins to false, the checkbox in preferences is still clickable and when you click it, it enables the two preferences below it.

I'm looking.

Comment 10

[Mike Kaply [:mkaply]]

This was broken by bug 1620753.

Unfortunately the test for this policy only checked the pref, not the UI.

Comment 11

[Mike Kaply [:mkaply]]

Attachment: Bug 1692159 - Disable saved password preference if disabled by policy. r?mixedpuppy!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bca5dcbda04
Disable saved password preference if disabled by policy. r=mixedpuppy,preferences-reviewers

Comment 13

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5bca5dcbda04