Closed Bug 1620753 Opened 1 year ago Closed 7 months ago

Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension

Categories

(WebExtensions :: Frontend, defect, P2)

73 Branch
Desktop
All
defect

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: aymericarnoult, Assigned: tgiles, NeedInfo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [passwords:capture-UI])

Attachments

(3 files)

Attached image Capture.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:73.0) Gecko/20100101 Firefox/73.0

Steps to reproduce:

Activated password remember and autofill option

Actual results:

The option regularly unactivates on its own

Expected results:

The option should stay activated

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Password Manager
Product: Firefox → Toolkit

The issue is that extensions have the ability to disable it but the UI doesn't indicate which extension did it. It's likely another password manager extension. See https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/privacy/services#Properties

Shane, I think we talked about this at All Hands. Is there a bug on this already or should we use this one? If so, does it belong in the extension component or here? If here, do you have a code pointer for how to show the UI about which extension is managing a pref in about:preferences?

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mixedpuppy)
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → Desktop
Summary: Options password autofill unactivates → Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension

The meta for preferences issues is bug 1578508. I think I'll just move this over. There are several bugs about exposing what extension controls a setting, but not one specific to the privacy api. Removing priority for our triage queue.

Blocks: 1578508
Component: Password Manager → Frontend
Flags: needinfo?(mixedpuppy)
Priority: P2 → --
Product: Toolkit → WebExtensions
Whiteboard: [passwords:capture-UI]

Mark, can you please check this out, seems somewhat important?

Flags: needinfo?(mstriemer)
Priority: -- → P2
Assignee: nobody → tgiles
Status: NEW → ASSIGNED
Attachment #9167410 - Attachment description: Bug 1620753 - Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension → Bug 1620753 - Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension. r=mstriemer
Pushed by abutkovits@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d32e55b4741
Indicate to the user when privacy.services.passwordSavingEnabled has set a new value via an extension. r=mstriemer,fluent-reviewers,preferences-reviewers,flod,mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Steps to reproduce:

  1. Load test extension test_remember_signon_ui-1.0.zip
  2. Navigate to about:preferences
  3. Navigate to the "Privacy & Security" tab
  4. Ensure the "Ask to save logins and passwords for websites" checkbox is enabled
  5. Activate test extension
  6. Verify that a box appears notifying the user an extension is controlling this preference
  7. Verify that "Ask to save logins and passwords for websites" checkbox is disabled.
  8. Verify that "Ask to save logins and passwords for websites" checkbox value has not changed.
  9. Click "Disable Extension"
  10. Verify that "Ask to save logins and passwords for websites" checkbox is enable AND its value has not changed
Flags: qe-verify+
Regressions: 1660998
You need to log in before you can comment on or make changes to this bug.