Support mozbuild 3.3 in SeaMonkey
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(seamonkey2.53+ fixed, seamonkey2.57esr? affected)
People
(Reporter: frg, Assigned: frg)
References
Details
Attachments
(3 files)
|
954 bytes,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
2.42 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
|
1.46 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-release+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Currently if you try to compile under Windows with mozbuild 3.3 the l10 packager will fail and the Lightning add-on will have an invalid id in its en-US install.rdf. This is mostly a 2.53 and 2.57 bug affecting makefiles but some of this is still in comm-central.
Cause is that defines in Makefiles used for the python preprocessor with double quotes and curly brackets are not expanded correctly. This isn't a problem for other mozilla based products because there are no similar cases left in Gecko code. Ours will go away later but need to be fixed in the interim.
|
Assignee | |
Comment 1•4 years ago
|
||
Patch for all trees.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: This one seems harmless and only there for uniformity
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --
|
|
Assignee | |
Comment 2•4 years ago
•
|
||
Patch for SeaMonkey 2.53 and 2.57 release branch only.
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: wrong extension id in calendar install.rdf
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --
|
|
Assignee | |
Comment 3•4 years ago
|
||
Patch for all trees. Depends on Bug 1551033
[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: cZ l10n merge abends
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: --
Comment on attachment 9202581 [details] [diff] [review]
1692200-mozbuild33-suite-2537.patch
[Triage Comment]
r/a=me LGTM
Comment on attachment 9202582 [details] [diff] [review]
1692200-mozbuild33-cal-2537.patch
[Triage Comment]
r/a=me LGTM
Comment on attachment 9202584 [details] [diff] [review]
1692200-mozbuild33-irc-2537.patch
[Triage Comment]
r/a=me LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e7a4dd13e7c4
Enclose path in single quotes to fix Windows mozbuild 3.3. breakage. r=IanN
https://hg.mozilla.org/comm-central/rev/21c5d865161e
Enclose INSTALL_EXTENSION_ID in single quotes to fix Windows mozbuild 3.3. breakage. r=IanN
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 8•4 years ago
|
||
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/cbbedb152bd1749ade6c6b781439d7c70945fbb7
Enclose XPI_EM_ID in single quotes to fix Windows mozbuild 3.3. breakage. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/afb2ae070a9b7fdffc78a412cf3e9c0f94d9733d
Enclose path in single quotes to fix Windows mozbuild 3.3. breakage. r=IanN a=IanN
https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/a9eb5c895f5cc603142b30d2592cc92cf5bd78b1
Enclose INSTALL_EXTENSION_ID in single quotes to fix Windows mozbuild 3.3. breakage. r=IanN a=IanN
Target 2.53.7
Description
•