1551033 - Fork ChatZilla into SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, task)

Description

[Ian Neal]

In order to fold ChatZilla and DOM Inspector into SeaMonkey, the existing files (and preferably histories) need to be pulled into comm-* from their respective repositories but without any branches.
The first step for each would be to clone the repository and run hg convert --filemap to move the files into suite/extensions/[irc|inspector] and strip anything that is not the default branch
The next step would be to bring the information into comm-*.
Questions:
Is there a way of doing this, whilst keeping the history of about 2500 changes, without polluting the recent changelog?
What is the best way of importing the files and history?

Comment 1

[Ian Neal]

Other times we have imported into an area of suite/ we have pulled the complete history in and attached to the tip of the comm repositories. We'd do as two sets, one for ChatZilla and one for DOM Inspector.
Any issues with this being done for comm-central, comm-esr60 and the SM2.53 branch on comm-release?

Comment 2

[Magnus Melin [:mkmelin]]

Why do you want to do it now, after all these years?
And aren't both of those super dead since at least a year or two?

I'm not sure anyone really cares if it's for comm-esr60 or the sm branch only, but I don't think we should add dead code to comm-central.

For how, hg convert indeed. I don't think there is any way of not polluting recent changelogs, at least the ones showing commits based on time.

Comment 3

[Ian Neal]

(In reply to Magnus Melin [:mkmelin] from comment #2)

Why do you want to do it now, after all these years?
And aren't both of those super dead since at least a year or two?

I'm not sure anyone really cares if it's for comm-esr60 or the sm branch only, but I don't think we should add dead code to comm-central.

For how, hg convert indeed. I don't think there is any way of not polluting recent changelogs, at least the ones showing commits based on time.
The current long term plan is to integrate them into SM rather than them be add-ons, but also get localisation working smoothly for them which I think won't happen whilst they're in separate repos and not showing in comm-central

Comment 4

[Robert Kaiser]

I wonder how useful this is for DOMI as we have a DOM inspection tool in devtools as well (I know, somewhat different, but still similar). For ChatZilla, I see a better case in general.

Comment 5

[Magnus Melin [:mkmelin]]

There are likely some changes coming for l10n and thunderbird (separate repo), so having the code in comm-central won't likely make anything any easier.

I think the better question is, do you actually see any chance for a seamonkey based on anything past 60? I have to say it would appear extremely unlikely you can pull that off from my POV.

Comment 6

[Ian Neal]

Attachment: 1551033-suite-extension-2537.patch

Changes needed for the move into suite/extensions

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9201874 [details] [diff] [review]
1551033-suite-extension-2537.patch

LGTM

There is room for improvement in the build files but I would do this in a follow-up. Personally I don't need the history in c-c and would be ok with just importing the current source which should not really add much.

Next step would be to integrate and get rid of the extension.

Comment 8

[Frank-Rainer Grahl (:frg)]

Attachment: 1551033-cZ-initial-import-cc.patch

Initial import patch of the cZ source without history. IanN did it. r+ from me.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 1551033-suite-extension-cc.patch

Rebased intial build patch. en-US works here but l10n packaging not. This is expected and goses away after integration the sources later. r+ from me.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c19a0da417e2
Initial import of ChatZilla sources into SeaMonkey. r=frg
https://hg.mozilla.org/comm-central/rev/7517593cc9c5
Fork ChatZilla into SeaMonkey - changes for move. r=frg

Comment 11

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/238eb10d8972019e2275ea3dd412ab28ffbd73a0
Fork ChatZilla into SeaMonkey - changes for move. r=frg a=frg
Target 2.53.7

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/44cede9f3ffc
Fix build warnings. r=me