1692218 - Add Page Action Menu use counter pref for share buttons

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Mike de Boer [:mikedeboer]]

For Proton onboarding purposes, we should add an IntPrefs like

• browser.engagement.pam-copyURL.used-count
• browser.engagement.pam-emailLink.used-count
• browser.engagement.pam-shareURL.used-count
  (proposed names by UX) right where the browser_ui_interaction_pageaction_panel.[copyURL|emailLink|shareURL] keyed scalar telemetry probes are incremented.

These prefs do not need to be added to firefox.js.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1692218 - Add Page Action Menu use counter prefs. r=harry

Also includes:
https://bugzilla.mozilla.org/show_bug.cgi?id=1692216
https://bugzilla.mozilla.org/show_bug.cgi?id=1692215

Comment 2

[Marco Bonardo [:mak]]

To be consistent with the .has-used prefs, I went with:
browser.engagement.pageAction-panel-copyURL.used-count
browser.engagement.pageAction-panel-emailLink.used-count
browser.engagement.pageAction-panel-pinTab.used-count
browser.engagement.pageAction-panel-screenshots_mozilla_org.used-count
browser.engagement.pageAction-panel-shareURL.used-count

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78fac34502cc
Add Page Action Menu use counter prefs. r=harry

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/78fac34502cc

Comment 5

[Florencia Di Ciocco, NI to vbalducci]

Hi Marco, How can I verify this bug?

Thanks, Flor.

Comment 6

[Marco Bonardo [:mak]]

(In reply to Florencia Di Ciocco, QA from comment #5)

Hi Marco, How can I verify this bug?

1. Click on page action buttons like: copy url, email link, pin tab, screenshot, share url
2. check the corresponding pref gets increased, the prefs are in comment 2

Comment 7

[Florencia Di Ciocco, NI to vbalducci]

Thanks Marco. Do I need any specific pref on? Because I have browser.proton.enabled, browser.proton.urlbar.enabled, and browser.proton.urlbar.enabled set on true, but I still see the following keyed scalar:

"browser.ui.interaction.pageaction_panel": {
"pinTab": 1,
"copyURL": 1,
"shareURL": 1,
"screenshots-mozilla-org": 1,
"emailLink": 1
},

I'm working on 87.0b2.

Comment 8

[Marco Bonardo [:mak]]

(In reply to Florencia Di Ciocco, QA from comment #7)

Thanks Marco. Do I need any specific pref on? Because I have browser.proton.enabled, browser.proton.urlbar.enabled, and browser.proton.urlbar.enabled set on true, but I still see the following keyed scalar:

This does not require proton, and it's not telemetry, just look for prefs in about:config.

Comment 9

[Florencia Di Ciocco, NI to vbalducci]

Ups, thanks. I've verified this on Beta 87.0b3 and I see the new prefs. I've updated the bug status.