Closed Bug 1692218 Opened 10 months ago Closed 10 months ago

Add Page Action Menu use counter pref for share buttons

Categories

(Firefox :: Address Bar, task, P1)

task
Points:
2

Tracking

()

VERIFIED FIXED
87 Branch
Iteration:
87.2 - Feb 8 - Feb 21
Tracking Status
firefox87 --- verified

People

(Reporter: mikedeboer, Assigned: mak)

References

(Blocks 1 open bug)

Details

(Whiteboard: [proton-address-bar])

Attachments

(1 file)

For Proton onboarding purposes, we should add an IntPrefs like

  • browser.engagement.pam-copyURL.used-count
  • browser.engagement.pam-emailLink.used-count
  • browser.engagement.pam-shareURL.used-count
    (proposed names by UX) right where the browser_ui_interaction_pageaction_panel.[copyURL|emailLink|shareURL] keyed scalar telemetry probes are incremented.

These prefs do not need to be added to firefox.js.

Assignee: nobody → mak
Status: NEW → ASSIGNED

To be consistent with the .has-used prefs, I went with:
browser.engagement.pageAction-panel-copyURL.used-count
browser.engagement.pageAction-panel-emailLink.used-count
browser.engagement.pageAction-panel-pinTab.used-count
browser.engagement.pageAction-panel-screenshots_mozilla_org.used-count
browser.engagement.pageAction-panel-shareURL.used-count

Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/78fac34502cc
Add Page Action Menu use counter prefs. r=harry
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Blocks: 1692216
Blocks: 1692215
Iteration: --- → 87.2 - Feb 8 - Feb 21

Hi Marco, How can I verify this bug?

Thanks, Flor.

Flags: needinfo?(mak)

(In reply to Florencia Di Ciocco, QA from comment #5)

Hi Marco, How can I verify this bug?

  1. Click on page action buttons like: copy url, email link, pin tab, screenshot, share url
  2. check the corresponding pref gets increased, the prefs are in comment 2
Flags: needinfo?(mak)

Thanks Marco. Do I need any specific pref on? Because I have browser.proton.enabled, browser.proton.urlbar.enabled, and browser.proton.urlbar.enabled set on true, but I still see the following keyed scalar:

"browser.ui.interaction.pageaction_panel": {
"pinTab": 1,
"copyURL": 1,
"shareURL": 1,
"screenshots-mozilla-org": 1,
"emailLink": 1
},

I'm working on 87.0b2.

Flags: needinfo?(mak)

(In reply to Florencia Di Ciocco, QA from comment #7)

Thanks Marco. Do I need any specific pref on? Because I have browser.proton.enabled, browser.proton.urlbar.enabled, and browser.proton.urlbar.enabled set on true, but I still see the following keyed scalar:

This does not require proton, and it's not telemetry, just look for prefs in about:config.

Flags: needinfo?(mak)

Ups, thanks. I've verified this on Beta 87.0b3 and I see the new prefs. I've updated the bug status.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.