Closed Bug 1692238 Opened 5 years ago Closed 5 years ago

Dark mode menu styling not applied in Library window or sidebar

Categories

(Firefox :: Menus, defect, P3)

Product:
Firefox
Component:
Menus
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
87 Branch
Tracking Flags:
Tracking Status
firefox87 --- verified
firefox88 --- verified
firefox89 --- verified

People

(Reporter: molly, Assigned: molly)

References

Details

(Whiteboard: [proton-context-menus][fixed by bug 1692237])

Context menus appearing in the library window or in any sidebar use the light theme no matter what the browser's theme is set to, even through the rest of the window/sidebar is dark.

Severity: -- → N/A
Priority: -- → P3
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED

I picked this up, but I think it might be fixed by https://phabricator.services.mozilla.com/D104930 ?

Flags: needinfo?(mhowell)

Yes, it looks that way. Should have pointed that out here, sorry.

Flags: needinfo?(mhowell)

(In reply to Molly Howell (she/her) [:mhowell] from comment #2)

Yes, it looks that way. Should have pointed that out here, sorry.

Don't be sorry, yay for fixed bugs!

Assignee: gijskruitbosch+bugs → mhowell
Hardware: Unspecified → Desktop
Whiteboard: [proton-context-menus] → [proton-context-menus][fixed by bug 1692237]
Version: unspecified → Trunk
Depends on: 1692237
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 87 Branch
Depends on: 1695990

This is verified fixed using Firefox 87.0 (BuildId:20210318103112), Firefox 88.0b1 (BuildId:20210322185611) and Firefox 89.0a1 (BuildId:20210322174641) on Windows 10 64bit.

Status: RESOLVED → VERIFIED
status-firefox87: fixed → verified
status-firefox88: --- → verified
status-firefox89: --- → verified
No longer depends on: 1695990
You need to log in before you can comment on or make changes to this bug.