169231 - remove editorshell from nsHTMLEditorLog.cpp

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

nsHTMLEditorLog.cpp needs to remove its references to editorShell

Comment 1

[Kathleen :Brade]

Attachment: patch to not use editorshell and to fix some commands which were missing params

Comment 2

[Akkana Peck]

Comment on attachment 99543 [details] [diff] [review]
patch to not use editorshell and to fix some commands which were missing params

> -    Write("window.editorShell.DeleteSelection(");
> +    Write("window.editor.deleteSelection(");

I didn't think we had a window.editor -- don't we need to make a getEditor()
routine, or something like that, like Charley has been doing in his dialog
code?  Charley?

Comment 3

[Charles Manske]

Yes, we are using GetCurrentEditor() everywhere instead of "window.gEditor"
or any other assumed editor global. This will all for whatever multiple editor
or frameset mechanisms we later implement.

Comment 4

[Kathleen :Brade]

Attachment: updated patch that uses GetCurrentEditor()

Comment 5

[Akkana Peck]

Comment on attachment 99552 [details] [diff] [review]
updated patch that uses GetCurrentEditor()

>@@ -331,5 +339,5 @@
>   {
>     PrintSelection();
>-    Write("window.editorShell.Paste();\n");
>+    Write("GetCurrentEditor().paste();\n");
>     Flush();
>   }

I believe Paste and all the PasteAs*Quotation variants all (selectionType).

That's the only problem I noticed, though; fix those, and r=akkana.

Comment 6

[Kathleen :Brade]

Actually, only Paste was missing the selectionType (not a regression from this
patch either).  PasteAsQuotation, PasteAsPlaintextQuotation and
PasteAsCitedQuotation already write out aSelectionType.

Comment 7

[kinmoz]

Comment on attachment 99552 [details] [diff] [review]
updated patch that uses GetCurrentEditor()

sr=[e-mail]

==== Do we want to avoid using "var"? My concern is you will get a JS error if
this gets written more than once to the same file. There are a couple of
methods which use "var":

+    Write("var atomService =
Components.classes[\"@mozilla.org/atom-service;1\"].getService(Components.inter
faces.nsIAtomService);\n");
+    Write("var propAtom = atomService.getAtom(\"");


==== In all the pasteAsQuotation() and pasteAsCitedQuotation() calls, do we
want to write out the selection type as a constant instead of an int?

  Components.interfaces.nsIClipboard.kGlobalClipboard;

Comment 8

[Kathleen :Brade]

patch checked in with changes as suggested by Akkana and Kin