1692339 - Add a "Redo" option underneath "Undo" in context menu for form fields

Status: VERIFIED FIXED

(Toolkit :: Form Manager, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

Discussion/spec: https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=6021888d#slide=id.gb7754f26c5_10_79

This was last proposed in bug 362738, where the decision was to WONTFIX. I don't know if any of the reasoning at that time is still relevant?

Comment 1

[Sam Foster [:sfoster] (he/him)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #0)

This was last proposed in bug 362738, where the decision was to WONTFIX. I don't know if any of the reasoning at that time is still relevant?

Specifically, we should confirm this is no longer true: "Redo" isn't in platform-native textboxes on Windows, so I don't think it should be re-added there

Comment 2

[:Gijs (he/him)]

(In reply to Sam Foster [:sfoster] (he/him) from comment #1)

(In reply to Sam Foster [:sfoster] (he/him) from comment #0)

This was last proposed in bug 362738, where the decision was to WONTFIX. I don't know if any of the reasoning at that time is still relevant?

Specifically, we should confirm this is no longer true: "Redo" isn't in platform-native textboxes on Windows, so I don't think it should be re-added there

It's still true in e.g. notepad, but not in other apps - worth noting that in particular, both Chrome and Edge have a "redo" item. After conferring with UX, we're comfortable with going ahead with this change.

Comment 3

[Michelle Goossens [:masterwayz]]

Attachment: Bug 1692339 - Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2091ee84e0e
Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_contextmenu_keyword.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/733353cf70469fa29d8d70faa1f165508100aab8

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=HUP1GCHnQgmfb5mzFHbCkw.0&revision=a2091ee84e0e282bba41939d6ec9081a19423dd4&searchStr=os%2Cx%2C10.14%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-macosx1014-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc5

Failure log: https://treeherder.mozilla.org/logviewer?job_id=331392404&repo=autoland&lineNumber=5932

Comment 6

[Michelle Goossens [:masterwayz]]

That test didn't exist yet when I made that patch.
Running https://treeherder.mozilla.org/jobs?repo=try&revision=d681eb0e18c6485d69dd517113c7a53ee1ac51a2 just to be sure of any new tests that were put in quietly. Phab revision has been updated.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc38bbdc40e0
Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/fc38bbdc40e0

Comment 9

[Bogdan Maris, Desktop Test Engineering]

Verified that the Redo option is present into form fields and it works as expected. There was one issue found by QA with the Redo option but that will be addressed in Bug 1697876 . Verified with latest Nightly 88.0a1 across platforms (Windows 10, macOS 11.3 and Ubuntu 18.04).