Closed Bug 1691660 Opened 3 years ago Closed 3 years ago

[meta] Proton refresh - password manager context menu changes

Categories

(Toolkit :: Password Manager, enhancement, P2)

Product:
Toolkit
Component:
Password Manager
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- verified
firefox89 --- verified

People

(Reporter: RT, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: meta, Whiteboard: [proton-context-menus])

User Story

Required changes to login ans password context menus for Proton alignment:
- Login Field:
-- If the user has a saved username
---Remove empty state “No login suggestions.”
---Bring "saved username" and "View Saved Login"s to top level and re-label to "Use Saved Login>" (brings up the logins drop-down) and 'Manage Logins..."
---Add a "Redo" option underneath "Undo"
---Remove "Add a keyword for this search"
-- If the user does not have a saved username
---Remove empty state “No login suggestions.”
---Bring "View Saved Login"s to top level and re-label to  'Manage Logins..."
---Add a "Redo" option underneath "Undo"
---Remove "Add a keyword for this search"
Details and discussions on https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=6021888d#slide=id.gb7754f26c5_10_79

- Password field:
-- If the user has a saved password
---Remove empty state “No login suggestions.”
--- Re-label "Fill Password" to "Use Saved Password" and "View Saved Logins" to 'Manage Logins...". Also bring these options to top level.
---Relabel “Use Generated Password…” to "Suggest Strong Password..."
Renamed  “Use Generated Password…”
---Add a "Redo" option underneath "Undo"
---Remove "Add a keyword for this search"
-- If the user does not have a saved password
---Remove empty state “No login suggestions.”
--- Re-label "View Saved Logins" to 'Manage Logins...". Also bring this options to top level.
---Relabel “Use Generated Password…” to "Suggest Strong Password..."
Renamed  “Use Generated Password…”
---Add a "Redo" option underneath "Undo"
---Remove "Add a keyword for this search"

Details and discussions on https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit?ts=6021888d#slide=id.gb7c6075fe8_1_17
No description provided.
User Story: (updated)
Keywords: meta
Summary: Proton refresh - password manager context menu changes → [meta] Proton refresh - password manager context menu changes
Severity: -- → N/A
Priority: -- → P2
Blocks: proton-context-menus
Whiteboard: [proton-context-menus]
Depends on: 1692322
Depends on: 1692329
Depends on: 1692330
Depends on: 1692333
Depends on: 1692339
No longer depends on: 1692339

Do we want all these changes behind a proton pref, or are they ok to land and ship normally? I ask because I don't think they necessarily need to be Proton-specific, but it changes the implementation significantly either way.

Flags: needinfo?(gijskruitbosch+bugs)

(In reply to Sam Foster [:sfoster] (he/him) from comment #1)

Do we want all these changes behind a proton pref, or are they ok to land and ship normally? I ask because I don't think they necessarily need to be Proton-specific, but it changes the implementation significantly either way.

Per https://mozilla.slack.com/archives/G01HZMZ54KD/p1611766460085500 , yes, they're OK to ship normally (none of these involve removals that break critical features in some way where we need to wait for an equivalent item to be available elsewhere).

Flags: needinfo?(gijskruitbosch+bugs)

All the deps are fixed so I think this is fixed.

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch

This is verified fixed using Firefox 88.0b1 (BuildId:20210322185611) and Firefox 89.0a1 (BuildId:20210322174641).

Status: RESOLVED → VERIFIED
status-firefox88: fixed → verified
status-firefox89: --- → verified
Depends on: 1701704
You need to log in before you can comment on or make changes to this bug.