Closed
Bug 1692438
Opened 4 years ago
Closed 4 years ago
Port bug 1692113 to Thunderbird: Review usages of `.getAttribute("hidden")` and rely on the DOM property instead when relevant
Categories
(Thunderbird :: Upstream Synchronization, task)
Thunderbird
Upstream Synchronization
Tracking
(thunderbird_esr78 wontfix, thunderbird86 wontfix)
RESOLVED
FIXED
87 Branch
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file)
|
18.12 KB,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1692113 +++
Stop checking against "true" and potentially rely on the DOM property when relevant.
https://searchfox.org/comm-central/search?q=getAttribute(%22hidden%22)&path=
|
Assignee | |
Updated•4 years ago
|
Status: NEW → ASSIGNED
status-thunderbird86:
--- → wontfix
status-thunderbird_esr78:
--- → wontfix
Target Milestone: --- → 87 Branch
|
|
Assignee | |
Comment 1•4 years ago
|
||
Attachment #9202861 -
Flags: review?(alessandro)
|
||
Comment 2•4 years ago
|
||
Comment on attachment 9202861 [details] [diff] [review]
bug1692438_hiddentrueattr_rm.patch
Review of attachment 9202861 [details] [diff] [review]:
-----------------------------------------------------------------
These changes look correct. r+
Attachment #9202861 -
Flags: review?(alessandro) → review+
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7cb28aa57f29
Port bug 1692113 to Thunderbird: Review usages of .getAttribute("hidden") and rely on the DOM property instead when relevant. r=aleca
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•