1692647 - Streamline Objective C exception handling in native menu code

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task, P3)

Description

[Markus Stange [:mstange]]

In this bug I want to convert the menu code to use fatal exception guards (bug 1693389), and to use them consistently (bug 1693392).

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1692647 - Make Objective C exceptions fatal in menu code. r=spohl

Fatal exceptions make it easier to reason about code, because early "abondonment"
reduces the number of failure states that the code needs to handle. None of the
Objective C calls we make in menu code is supposed to throw an exception; by
crashing eagerly, we can quickly find out which ones do.

Since this patch can introduce new crashes, I would like to get it patch into
Nightly as quickly as possible so that we can watch crash stats and find any
"expected" exceptions, and add custom handling for them.

Depends on D105516

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1692647 - Apply new exception guard policy to the menu code: Non-throwing functions need to guard if they call throwing functions, see bug 1693392. r=spohl

This patch removes exception guards from a number of Objective C methods, and
introduces exception guards to a number of C++ methods. The goal is to guard the
"boundary" between the two worlds.

Depends on D105517

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb723067be18
Make Objective C exceptions fatal in menu code. r=spohl
https://hg.mozilla.org/integration/autoland/rev/b03a44019284
Apply new exception guard policy to the menu code: Non-throwing functions need to guard if they call throwing functions, see bug 1693392. r=spohl

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/eb723067be18
https://hg.mozilla.org/mozilla-central/rev/b03a44019284