1699936 - Crash in [@ nsMenuBarX::Paint] with NSInvalidArgumentException: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P3)

Description

[Markus Stange [:mstange]]

Crash report: https://crash-stats.mozilla.org/report/index/c8049cd0-e2c0-4e47-8f2a-526140210319

MOZ_CRASH Reason: MOZ_CRASH(Encountered unexpected Objective C exception)

Obj-C Exception data:
NSInvalidArgumentException: *** -[__NSArrayM insertObject:atIndex:]: object cannot be nil

Thrown at stack:

__exceptionPreprocess (in CoreFoundation) + 0x93
objc_exception_throw (in libobjc.A.dylib) + 0x30
_CFThrowFormattedException (in CoreFoundation) + 0xc2
-[__NSArrayM insertObject:atIndex:] (in CoreFoundation) + 0x4dd
-[NSMenu insertItem:atIndex:] (in AppKit) + 0x12e
nsMenuBarX::Paint() (in XUL) + 0x6f

Top 10 frames of crashing thread:

0 XUL nsMenuBarX::Paint widget/cocoa/nsMenuBarX.mm:459
1 XUL nsMenuBarX::Create widget/cocoa/nsMenuBarX.mm:148
2 XUL mozilla::widget::NativeMenuSupport::CreateNativeMenuBar widget/cocoa/NativeMenuSupport.mm:18
3 XUL mozilla::LoadNativeMenus xpfe/appshell/AppWindow.cpp:3006
4 XUL mozilla::dom:: dom/promise/Promise.cpp:384
5 XUL mozilla::dom::NativeHandlerCallback dom/promise/Promise.cpp:337
6 XUL js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:520
7 XUL mozilla::dom::CallbackObject::CallSetup::~CallSetup dom/bindings/CallbackObject.cpp:342
8 XUL js::Call js/src/vm/Interpreter.cpp:597
9 XUL PromiseReactionJob js/src/builtin/Promise.cpp:1905

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1692647

Comment 2

[Gian-Carlo Pascutto [:gcp]]

P2 for over a year doesn't seem to reflect reality and there is no-one assigned. I'm going to reset this.

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Bug 1699936: Prevent possible crashes due to Objective-C exceptions when drawing the menubar on macOS. r=mstange

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/338840bec053
Prevent possible crashes due to Objective-C exceptions when drawing the menubar on macOS. r=mstange

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/338840bec053

Comment 6

[Stephen A Pohl [:spohl]]

Attachment: Bug 1699936: Backout 338840bec053 for causing bug 1765524.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5515af3719ef
Backout 338840bec053 for causing bug 1765524. r=mstange

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5515af3719ef

Comment 9

[Dianna Smith [:diannaS]]

:spohl do you still plan on working on this?

Comment 10

[Stephen A Pohl [:spohl]]

I happen to be looking at an issue that deals with menu items in bug 1642138 and I'll keep this bug in mind.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 5 desktop browser crashes on Mac on beta (startup)

:spohl, could you consider increasing the severity of this top-crash bug?

For more information, please visit auto_nag documentation.

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Based on the topcrash criteria, the crash signature linked to this bug is not a topcrash signature anymore.

For more information, please visit auto_nag documentation.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3d4fed7df6d2
Prevent possible crashes due to Objective-C exceptions when drawing the menubar on macOS. r=mstange

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3d4fed7df6d2

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:spohl, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval. Also, don't forget to request an uplift for the patches in the regression caused by this fix.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Stephen A Pohl [:spohl]]

(In reply to BugBot [:suhaib / :marco/ :calixte] from comment #15)

The patch landed in nightly and beta is affected.
:spohl, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval. Also, don't forget to request an uplift for the patches in the regression caused by this fix.
• If no, please set status-firefox121 to wontfix.

For more information, please visit BugBot documentation.

Since this is a longstanding issue and that the patch here has caused regressions before, it does not seem prudent to uplift it at this time. Setting status-firefox121 to wontfix.