1692677 - tb debug perma assertion failure: !disp->IsAbsolutelyPositionedStyle() || disp->DisplayInside() != StyleDisplayInside::MozBox (was blockified but isn't any longer! It probably needs explicit 'display:block' ), at layout/base/nsCSSFrameConstructor.cpp:5545

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=329826142&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/MgurisbgR-uvUz8x0_i0-Q/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin]]

Assertion failure: !disp->IsAbsolutelyPositionedStyle() || disp->DisplayInside() != StyleDisplayInside::MozBox (This may be a frame that was previously blockified but isn't any longer! It probably needs explicit 'display:block' to preserve behavior), at /builds/worker/checkouts/gecko/layout/base/nsCSSFrameConstructor.cpp:5545

Something changed with https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=668376949c26fc346f02e74a40836ad999172dc4

Comment 2

[Geoff Lankow (:darktrojan)]

It seems that the tests in question all involve a compose window.

Comment 3

[Geoff Lankow (:darktrojan)]

Backout of https://hg.mozilla.org/comm-central/rev/8bb80263dee66803a38e74bc0bca714a1ab3620d fixes it. I'm not going to do that just yet as I'm not that worried about debug BCT failures. Now to figure out why.

Comment 4

[Geoff Lankow (:darktrojan)]

This line is causing the assertion failure: https://hg.mozilla.org/comm-central/diff/8bb80263dee66803a38e74bc0bca714a1ab3620d/mail/themes/shared/mail/messengercompose.css#l1.86

Comment 5

[Intermittent Failures Robot]

26 failures in 4322 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 26

Platform and build breakdown:

• linux64: 5
  • debug: 5
• macosx1014-64: 5
  • debug: 5
• windows7-32: 6
  • debug: 6
• windows10-64: 10
  • debug: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692677&startday=2021-02-08&endday=2021-02-14&tree=all

Comment 6

[Intermittent Failures Robot]

39 failures in 501 pushes (0.078 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 39

Platform and build breakdown:

• windows7-32: 10
  • debug: 10
• windows10-64: 9
  • debug: 9
• linux64: 10
  • debug: 10
• macosx1014-64: 10
  • debug: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692677&startday=2021-02-15&endday=2021-02-15&tree=all

Comment 7

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/e041628b77df22c5f6e793733890e0c3709991d4/mail/components/compose/content/messengercompose.xhtml#2502
https://searchfox.org/mozilla-central/rev/a23e65c5d69a821f61d14c8ec1f69a120e3f77d1/layout/base/nsCSSFrameConstructor.cpp#5536-5540

That is from 1584638, see also bug 1582819 comment 0. If I'm reading it correctly, position:absolute is not to be used for an element that was -moz-box and flex.

Comment 8

[Magnus Melin [:mkmelin]]

Likely replacing #attachmentInfo with a div and the children with span/div will magically sort this out.
Maybe the dev tools can could tell which of the involved elements have the wrong characteristics.

Comment 9

[Alessandro Castellani [:aleca]]

Ouch, sorry for the issue.
I'll take care of this.

Comment 10

[Alessandro Castellani [:aleca]]

Converting those elements in HTML seems to do the trick like Magnus said: https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=8b6849d0b25145cc6acb384cbba89933d89f1a4f

Patch incoming.

Comment 11

[Alessandro Castellani [:aleca]]

Attachment: 1692677-test-failure.diff

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08ae9df8f829
Fix Assertion failure due to absolute positioned -moz-box element. r=darktrojan

Comment 13

[Intermittent Failures Robot]

20 failures in 709 pushes (0.028 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 20

Platform and build breakdown:

• linux64: 5
  • debug: 5
• windows7-32: 5
  • debug: 5
• windows10-64: 5
  • debug: 5
• macosx1014-64: 5
  • debug: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692677&startday=2021-02-16&endday=2021-02-16&tree=all

Comment 14

[Intermittent Failures Robot]

59 failures in 3737 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 59

Platform and build breakdown:

• windows7-32: 15
  • debug: 15
• windows10-64: 14
  • debug: 14
• linux64: 15
  • debug: 15
• macosx1014-64: 15
  • debug: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1692677&startday=2021-02-15&endday=2021-02-21&tree=all

Comment 16

[Ben Campbell]

Breadcrumb trail. I can't imagine this exact bug would pop up again, but just in case...
Over in Bug 1693435 I wrote up some steps to trigger it .