Closed Bug 1692745 Opened 1 year ago Closed 1 year ago

Remove Firefox and Thunderbird specific code from forked ChatZilla code

Categories

(SeaMonkey :: Chat, task)

Product:
SeaMonkey
Component:
Chat
Type:
task

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.84
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.7)

Attachments

(1 file, 1 obsolete file)

1692745-cz-ff-tb-xul-v1_1-2537.patch
33.42 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

In Bug 1551033 we forked the ChatZilla code into our repo, so we can now remove unneeded Firefox and Thunderbird parts.

Attached patch 1692745-cz-ff-tb-xul-2537.patch (obsolete) — — Splinter Review

This patch should remove the unneeded XUL and build config code.
Tested against 2.53.7 en-US and en-GB.

Attachment #9203109 - Flags: review?(frgrahl)
Attachment #9203109 - Flags: approval-comm-release?
Attachment #9203109 - Flags: approval-comm-esr60?

Changes since previous version:

  • Remove unused listbox.js
Attachment #9203109 - Attachment is obsolete: true
Attachment #9203109 - Flags: review?(frgrahl)
Attachment #9203109 - Flags: approval-comm-release?
Attachment #9203109 - Flags: approval-comm-esr60?
Attachment #9203114 - Flags: review?(frgrahl)
Attachment #9203114 - Flags: approval-comm-release?
Attachment #9203114 - Flags: approval-comm-esr60?
Component: General → Chat
See Also: → 1692758

Comment on attachment 9203114 [details] [diff] [review]
1692745-cz-ff-tb-xul-v1_1-2537.patch

LGTM

Attachment #9203114 - Flags: review?(frgrahl)
Attachment #9203114 - Flags: review+
Attachment #9203114 - Flags: approval-comm-release?
Attachment #9203114 - Flags: approval-comm-release+
Attachment #9203114 - Flags: approval-comm-esr60?
Attachment #9203114 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/c29f121572dd
Remove Firefox and Thunderbird specific code from forked ChatZilla code. r=frg

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Future

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/f2fdcfe118f3334b3209b39dd5a7d18e65eb92b7
Remove Firefox and Thunderbird specific code from forked ChatZilla code. r=frg a=frg
Target 2.53.7

status-seamonkey2.53: affected → fixed
tracking-seamonkey2.53: ? → +
Target Milestone: Future → seamonkey 2.84
You need to log in before you can comment on or make changes to this bug.