Open Bug 1692751 Opened 4 years ago Updated 4 years ago

Consider adding manually-added Top Sites to Places

Categories

(Firefox :: Address Bar, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: aryx, Unassigned)

References

Details

Attachments

(1 file)

Bug 1685133 added to option to suggest the shortcuts set on about:newtab (with browser.newtabpage.activity-stream.customizationMenu.enabled set to true) in the address bar. This doesn't work here with Firefox 86.0b9 and latest Nightly and I didn't find a bug for its implementation.

Steps to reproduce:

  1. Open about:config from the address bar.
  2. Set browser.newtabpage.activity-stream.customizationMenu.enabled to true.
  3. (Restart the browser but I doesn't make a difference here)
  4. Open Options/Preferences, go to Privacy & Security and check the option to suggest Shortcuts from the address bar is enabled.
  5. Open about:newtab
  6. In the top section, open the menu on the top right > "Add Top Site".
  7. Set Title as "test" and the url as one still unknown to the browser, e.g. https://www.weltzeit.de and save.
  8. Type test into the address bar. Expected: https://www.weltzeit.de suggested but isn't.
  9. Type weltzeit into address bar. Expected (?): https://www.weltzeit.de suggested but isn't.

If I understand this bug correctly, you expect that Top Sites manually added on the new tab page should be autofilled when they are typed in the address bar.

That's not how Top Sites are currently implemented. The address bar shows Top Sites when it is clicked and no search string has been typed. Adding Top Sites to autofill would be a new feature, so I'm marking this as an enhancement. I'm also removing the dependency on bug 1685133 since we've supported manually adding Top Sites for years. The customization menu behind browser.newtabpage.activity-stream.customizationMenu.enabled does not control that behaviour.

Severity: -- → N/A
Type: task → enhancement
Priority: -- → P3
Summary: suggest shortcuts in addressbar dropdown like settings suggest if browser.newtabpage.activity-stream.customizationMenu.enabled enabled → Consider adding manually-added Top Sites to Places

Just so I'm sure we're on the same page, here's a screen recording of how your STR are expected to work. I skipped the steps that enable browser.newtabpage.activity-stream.customizationMenu.enabled because that's not necessary to make this work.

Please let me know if I'm misunderstanding your report.

Thanks for the explanation and the video. I never saw the pin because I always hit Ctrl+L to type the url (or click on bookmarks in the bookmarks toolbar or sidebar). This in combination with the addition of the "Shortcuts" checkbox in 86 made me believe this is a new feature.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: