Closed Bug 1685133 Opened 3 years ago Closed 3 years ago

String changes due newtab updates

Categories

(Firefox :: New Tab Page, enhancement)

Firefox 86
enhancement

Tracking

()

VERIFIED FIXED
86 Branch
Tracking Status
firefox86 --- verified

People

(Reporter: ewright, Assigned: ewright)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The string "Recent Highlights" found in Application (Hamburger Menu) > Library > Recent Highlights should be changed to "Recent activity"

This section may be removed in the future, but for now we should change it to match our other newtab updates when the relevant pref is flipped.

Also, the string "top sites" in about:preferences#privacy should change to "Shortcuts"

Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c98a54c184d0
String changes due to newtab updates r=preferences-reviewers,prathiksha,fluent-reviewers,flod,ntim

Backed out for newtab failures.

backout: https://hg.mozilla.org/integration/autoland/rev/71b841eafdfd797e47967d18ebdb74bc7fc2a298

push: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=linux%2C18.04%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-newtab-unit-tests%2Cnewtab&revision=c98a54c184d049967c23034641016e22e6290d41&selectedTaskRun=UjyCeR8BSueGuJHnRzmEOw.0

failure log: https://treeherder.mozilla.org/logviewer?job_id=326203649&repo=autoland&lineNumber=90

[task 2021-01-08T17:05:21.578Z] added 1236 packages from 1803 contributors and audited 1314 packages in 15.628s
[task 2021-01-08T17:05:22.074Z]
[task 2021-01-08T17:05:22.074Z] 39 packages are looking for funding
[task 2021-01-08T17:05:22.074Z] run npm fund for details
[task 2021-01-08T17:05:22.074Z]
[task 2021-01-08T17:05:22.075Z] found 115 vulnerabilities (108 low, 3 moderate, 4 high)
[task 2021-01-08T17:05:22.075Z] run npm audit fix to fix them, or npm audit for details
[task 2021-01-08T17:05:22.763Z] + node bin/try-runner.js
[task 2021-01-08T17:05:22.817Z] TEST START | checkBundles
[task 2021-01-08T17:05:29.139Z] TEST-UNEXPECTED-FAIL checkBundles | Activity Stream bundle out of date
[task 2021-01-08T17:05:29.141Z] { checkBundles: false }
[task 2021-01-08T17:05:29.141Z] CODE 1
[taskcluster 2021-01-08 17:05:29.541Z] === Task Finished ===
[taskcluster 2021-01-08 17:05:29.541Z] Unsuccessful task run with exit code: 1 completed in 227.256 seconds

Flags: needinfo?(ewright)
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6b71f5fe37d
String changes due to newtab updates r=preferences-reviewers,prathiksha,fluent-reviewers,flod,ntim
Flags: needinfo?(ewright)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
Regressions: 1686331

I have verified this enhancement and I can confirm the following if the browser.newtabpage.activity-stream.newNewtabExperience.enabled pref is set to true:
- the Recent Highlights string from the Library menu is changed into the Recent activity one.
- the Top Sites string from the about:preferences#privacy page is changed into the "Shortcuts" one.

Verified using the latest Firefox Nightly (86.0a1 Build ID - 20210115035053) installed on Windows 10 x64, Mac 10.15.7, and Linux Mint 20 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: