1692815 - Crash in [@ brush_image_TEXTURE_2D_frag::brush_fs]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Gabriele Svelto [:gsvelto]]

Crash report: https://crash-stats.mozilla.org/report/index/8d6403c5-ec9c-4cb7-826b-64d390210215

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames of crashing thread:

0 xul.dll brush_image_TEXTURE_2D_frag::brush_fs x86_64-pc-windows-msvc/release/build/swgl-40828f65300b0388/out/brush_image_TEXTURE_2D.h:779
1 xul.dll static brush_image_TEXTURE_2D_frag::run x86_64-pc-windows-msvc/release/build/swgl-40828f65300b0388/out/brush_image_TEXTURE_2D.h:829
2 xul.dll draw_quad_spans<unsigned int> gfx/wr/swgl/src/gl.cc:4339
3 xul.dll draw_quad gfx/wr/swgl/src/gl.cc:4935
4 xul.dll DrawElementsInstanced gfx/wr/swgl/src/gl.cc:5055
5 xul.dll swgl::swgl_fns::{{impl}}::draw_elements_instanced gfx/wr/swgl/src/swgl_fns.rs:1645
6 xul.dll webrender::renderer::Renderer::draw_instanced_batch<webrender::gpu_types::PrimitiveInstanceData> gfx/wr/webrender/src/renderer/mod.rs:2509
7 xul.dll webrender::renderer::Renderer::draw_alpha_batch_container gfx/wr/webrender/src/renderer/mod.rs:2885
8 xul.dll webrender::renderer::Renderer::draw_frame gfx/wr/webrender/src/renderer/mod.rs:4476
9  @0x402e1febff 

This appears to be a crash on machines running WebRender's software back-end. It seems to affect both Windows and Linux so I guess it's not platform-dependent (which makes sense given it's happening in a software-only path).

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I can reproduce this.

Comment 2

[Lee Salzman [:lsalzman]]

Bug 1692029 might fix this once it lands.

Comment 3

[Jim Mathies [:jimm]]

(In reply to Lee Salzman [:lsalzman] from comment #2)

Bug 1692029 might fix this once it lands.

This work landed in 88. Crashes showing up in early beta in 87. We'll see if the fix helped after the next merge.

Comment 5

[Lee Salzman [:lsalzman]]

Crashes have mostly disappeared here, so it seems like we fixed it.