1692838 - Don't show cached messages from private window in the browser console

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

This only occurs when devtools.browsertoolbox.fission is true, as we connect directly to the frame target, and don't exclude private messages from the server.

browser_console_webconsole_private_browsing.js should have prevented the regression,
but in the test we check way to early to see if the messages are here, so we don't see that they actually get rendered later.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1642599

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1692838 - [devtools] Don't show cached message from private windows in browser console. r=ochameau.

First, this patch fixes the existing test that was flawed, checking if messages
weren't displayed too early, so messages didn't have the time to be rendered.
When checking later, we can see that the messages were displayed when they shouldn't have been.
We can't build a server-only solution here, as the browser console will consume
messages from frame targets, and we don't have a way to check if a given target
is consumed from the browser console/browser toolbox.
What we do is add a new isCachedMessage property on css, error and console messages
resources, so we can check it on the client alongside the private one.

Comment 3

[Chris Peterson [:cpeterson]]

Tracking DevTools Post-M8 bugs for Fission MVP milestone. They don't block the Fission Release channel experiment, but we would like them to be completed before we roll out Fission by default.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1692838 - [devtools] Add an `isAlreadyExistingResource` property to resources. r=ochameau.

This property indicates if the resources was existing before we started watching
for this type of resource.
We add some test cases in the various message resources to check the value of the
property.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dcb37229312
[devtools] Add an `isAlreadyExistingResource` property to resources. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/d30ecc76411c
[devtools] Don't show cached message from private windows in browser console. r=ochameau.

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8dcb37229312
https://hg.mozilla.org/mozilla-central/rev/d30ecc76411c