Remove the FrameTargetActor
Categories
(DevTools :: Framework, task, P3)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Unassigned)
References
Details
With https://phabricator.services.mozilla.com/D104391 landed, the only difference between the FrameTargetActor and its base class BrowsingContextTargetActor is the title implementation:
FrameTargetActor:
Object.defineProperty(frameTargetPrototype, "title", {
get: function() {
return this.window.document.title;
},
enumerable: true,
configurable: true,
});
BrowsingContextTargetActor
get webNavigation() {
return this.docShell.QueryInterface(Ci.nsIWebNavigation);
},
get contentDocument() {
return this.webNavigation.document;
},
get title() {
return this.contentDocument.contentTitle;
},
|
Reporter | |
Comment 1•4 years ago
|
||
See initial conversation at https://phabricator.services.mozilla.com/D104391#inline-585657
|
|
Reporter | |
Comment 2•4 years ago
|
||
After some tests I haven't found any situation where the BrowsingContextTargetActor's implementation of title could return a valid title?
I tested:
- webextension targets
- parent process targets
- chrome window targets
|
|
Reporter | |
Comment 3•4 years ago
|
||
The title getter was added 7 years ago in https://bugzilla.mozilla.org/show_bug.cgi?id=937172, but I am not sure it ever worked? contentTitle doesn't seem available on document: https://searchfox.org/mozilla-central/source/dom/webidl/Document.webidl
contentTitle only seems available on browser elements.
Maybe this was meant to point to document.title?
Description
•