1692940 - Switch from yasm to nasm

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

The last release of yasm was in 2014, and in most cases, we also require nasm on platforms where we require yasm. At the same time, we pass flags to yasm that make it take nasm syntax as input, so practically speaking, nasm can be used to replace yasm in a fairly straightforward manner. So instead of relying on two different assemblers, one of which is abandoned, rely on just one.

(This is also not a case of yasm being "finished" rather than abandoned. There are new instruction sets that yasm doesn't support but nasm does)

Comment 1

[Mike Hommey [:glandium]]

Note: even with bug 1693242 addressed, nasm is slower than yasm, but it also does (slightly) more work, such as using mov 42, %eax instead of mov 42, %rax (they do the same thing in practice (mov of 32-bits values in a 64-bits register clears the top-half of the 64-bits register) but encode in less bytes)

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Revert bug 1508419.

Back when bug 1508419 landed, we weren't using a bootstrapped nasm. It
is less useful now that we are.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Change the logic to check for nasm.

Instead of preemptively check for it, and then check if it's good enough to
build AV1, only check for (and bootstrap) nasm when building AV1 requires
it.

At the same time, we future-proof the code to be able to handle multiple
things requiring nasm, which we're going to add shortly.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Remove test case for yasm version validation.

We're going to remove arguments to the function, and eventually remove
it.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Switch vpx build to nasm instead of yasm.

We also remove the dependency on the check for GNU as, because all the
build environments we support for arm use GNU as, and the dependency
causes complications.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Switch jpeg build to nasm instead of yasm.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Switch ffvpx build to nasm instead of yasm.

nasm doesn't like compiling simple_idct10.asm on x86
(https://bugzilla.nasm.us/show_bug.cgi?id=3392738), which is empty once
preprocessed for x86, so exclude it there.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Switch aom build to nasm instead of yasm.

nasm doesn't like compiling x86_abi_support.asm
(https://bugzilla.nasm.us/show_bug.cgi?id=3392738), which is actually an
include file, rather than a source file, so it shouldn't have been in
the list of sources in the first place (libvpx has a similar file that
is excluded already, for instance).

I was considering updating the vendoring script, but it turns out it
doesn't produce the current contents in-tree (which even breaks the
build), and aom is set to be removed (bug 1635296)...

Comment 9

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Turn the USE_YASM unit test into a USE_NAME one.

Comment 10

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Remove build system support for yasm.

Comment 11

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Don't bootstrap yasm.

Comment 12

[Mike Hommey [:glandium]]

Attachment: Bug 1692940 - Don't install yasm in docker images.

We keep it in the Ubuntu image because that would mean rebuilding it,
which breaks things.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b391b7adca2
Revert bug 1508419. r=firefox-build-system-reviewers,andi,dmajor
https://hg.mozilla.org/integration/autoland/rev/a22f5d28effb
Change the logic to check for nasm. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/157125c6c140
Remove test case for yasm version validation. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/2d3e201b3724
Switch vpx build to nasm instead of yasm. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/2d78e4bc3367
Switch jpeg build to nasm instead of yasm. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/da0ee340f699
Switch ffvpx build to nasm instead of yasm. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/3b1e09a1e421
Switch aom build to nasm instead of yasm. r=firefox-build-system-reviewers,jbauman,dmajor,andi
https://hg.mozilla.org/integration/autoland/rev/d74f2f0996f9
Turn the USE_YASM unit test into a USE_NAME one. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/fdba4b86b00a
Remove build system support for yasm. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/2310bd4635a2
Don't bootstrap yasm. r=firefox-build-system-reviewers,dmajor
https://hg.mozilla.org/integration/autoland/rev/001f6152928a
Don't install yasm in docker images. r=firefox-build-system-reviewers,andi,dmajor

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07420cd09432
Fix bustages on Win 2012 AArch64. a=bustage-fix

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8b391b7adca2
https://hg.mozilla.org/mozilla-central/rev/a22f5d28effb
https://hg.mozilla.org/mozilla-central/rev/157125c6c140
https://hg.mozilla.org/mozilla-central/rev/2d3e201b3724
https://hg.mozilla.org/mozilla-central/rev/2d78e4bc3367
https://hg.mozilla.org/mozilla-central/rev/da0ee340f699
https://hg.mozilla.org/mozilla-central/rev/3b1e09a1e421
https://hg.mozilla.org/mozilla-central/rev/d74f2f0996f9
https://hg.mozilla.org/mozilla-central/rev/fdba4b86b00a
https://hg.mozilla.org/mozilla-central/rev/2310bd4635a2
https://hg.mozilla.org/mozilla-central/rev/001f6152928a
https://hg.mozilla.org/mozilla-central/rev/07420cd09432