1692984 - Add support for "webSocketUrl” capability to Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The additional boolean webSocketUrl capability is used to request a WebDriver BiDi websocket: https://w3c.github.io/webdriver-bidi/#establishing

Similar to the moz:debuggerAddress capability it needs to be validated by Marionette, and has make sure to create to return the Websocket URL. When webSocketUrl is set it should be asserted for true.

Returned will be a WebSocket URI:
https://w3c.github.io/webdriver-bidi/#construct-a-websocket-url

James, what actually defines the secure bit of the WebSocket connection? I assume that we should basically use it by default and only fallback if a secure connection cannot be established? I don't see how a client could actually request that.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually Marionette has to handle all that. Geckodriver just passes-through the URL.

James, mind having a look at my question from comment 0? Thanks.

Comment 2

[James Graham [:jgraham]]

https://w3c.github.io/webdriver-bidi/#start-listening-for-a-websocket-connection is called from the WebDriver New Session Algorithm in https://w3c.github.io/webdriver-bidi/#establishing Basically it's up to you whether the connection is ws:// or wss:// and the client has to deal with either.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to James Graham [:jgraham] from comment #2)

Basically it's up to you whether the connection is ws:// or wss:// and the client has to deal with either.

It would be good to know the overhead for secure websockets, but given that HTTPS is that highly promoted (versus HTTP) we should maybe also default to a secure websocket, which wouldn't allow sniffing on the network. If clients cannot handle that we might want to add another capability or preference to fallback to a non-secure websocket.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1692984 - [marionette] Add support for “webSocketUrl” capability.

Depends on D119552

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd61434c223f
[marionette] Add support for “webSocketUrl” capability. r=webdriver-reviewers,jdescottes,jgraham

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/fd61434c223f