1693180 - Skeleton UI does not show up when restarting for update

Status: RESOLVED FIXED

(Firefox :: General, defect, P3)

Description

[Alex Thayer [:alexical] (she/her)]

This is because when we trigger a restart, we set the XRE_PROFILE_PATH env var. We could show the skeleton UI correctly if we either supported multiple profiles (bug 1685572), or if we can just detect if the current profile is the default profile, in which case we would not need to set XRE_PROFILE_PATH (or we could set an additional env var to let the skeleton UI know that we should still be okay to display it.)

Comment 1

[Justin Peter]

When Firefox updates on startup, I see a very quick flash of the skeleton UI; is that also part of this bug?

Comment 2

[Justin Peter]

To clarify: If there is an update waiting to install, and rather than clicking the "restart to update" button in the menu, you close the browser, regardless of how long you wait, the skeleton UI will quickly flash and then disappear for a few seconds before starting up.

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1693180 - Ensure we show the skeleton UI when restarting FF r?emalysz

When restarting, we set the XRE_PROFILE_PATH env var. This normally would
prevent us from showing the skeleton UI. This patch just adds another env
var to indicate that we are restarting so the skeleton UI can know it's
safe to display.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61548bd74d75
Ensure we show the skeleton UI when restarting FF r=emalysz

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/61548bd74d75